Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix generics handling for function calls #1215

Merged
merged 7 commits into from
Jan 6, 2025
Merged

Fix generics handling for function calls #1215

merged 7 commits into from
Jan 6, 2025

Conversation

Nadrieril
Copy link
Collaborator

I've started checking for consistency of generics in charon, which revealed several inconsistencies in how we deal with function generics and function calls (mostly related to late-bound lifetime variables). This PR fixes a number of these issues.&

@Nadrieril Nadrieril changed the title Fix generic handling for function calls Fix generics handling for function calls Dec 31, 2024
@Nadrieril Nadrieril mentioned this pull request Dec 31, 2024
Merged
@Nadrieril Nadrieril requested a review from W95Psp December 31, 2024 14:22
@Nadrieril Nadrieril mentioned this pull request Jan 2, 2025
Open
W95Psp
W95Psp approved these changes Jan 6, 2025
View reviewed changes
Copy link
Collaborator

@W95Psp W95Psp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that looks good to me!

I had no idea about this subtyping in impls 🤯
(Every FullDef related PR you submit makes me want #1072 more 😄)

I only have a few nits

frontend/exporter/src/types/mir.rs Outdated Show resolved Hide resolved
frontend/exporter/src/types/mir.rs Outdated Show resolved Hide resolved
frontend/exporter/src/types/ty.rs Show resolved Hide resolved
frontend/exporter/src/types/mir.rs Outdated Show resolved Hide resolved
@Nadrieril Nadrieril requested a review from W95Psp January 6, 2025 15:11
@Nadrieril Nadrieril enabled auto-merge January 6, 2025 15:16
@Nadrieril Nadrieril added this pull request to the merge queue Jan 6, 2025
Merged via the queue into cryspen:main with commit 4d7cbff Jan 6, 2025
14 of 15 checks passed
@Nadrieril Nadrieril deleted the fix-call-generics branch January 6, 2025 15:46
This was referenced Jan 7, 2025
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@W95Psp W95Psp W95Psp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nadrieril @W95Psp