-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added a dummy Kyber implementation and test scaffolding #438
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
da4a57e
Added Kyber768 consistency test using a dummy implementation of Kyber.
xvzcf b31c57e
Added Kyber768 KAT tests.
xvzcf cea820e
Moved libcrux C files into a separate folder and updated configuratio…
xvzcf 9795943
Clang format.
xvzcf 4bdb7cc
format tools/configure.py
xvzcf 769e17d
Update default_config.cmake
xvzcf 0c24d49
Build libcrux separately in CMakeLists.txt
xvzcf 3202f74
Don't build libcrux by default.
xvzcf da37708
Merge branch 'dev' into goutam/libcrux-kyber
franziskuskiefer b396291
Rerun CI.
xvzcf File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,32 @@ | ||
#ifndef __Libcrux_Kem_Kyber_Kyber768_H | ||
#define __Libcrux_Kem_Kyber_Kyber768_H | ||
|
||
#if defined(__cplusplus) | ||
extern "C" | ||
{ | ||
#endif | ||
|
||
#include <inttypes.h> | ||
|
||
#define KYBER768_SECRETKEYBYTES 2400 | ||
#define KYBER768_PUBLICKEYBYTES 1184 | ||
#define KYBER768_CIPHERTEXTBYTES 1088 | ||
#define KYBER768_SHAREDSECRETBYTES 32 | ||
|
||
int Libcrux_Kyber768_GenerateKeyPair(uint8_t* pk, | ||
uint8_t* sk, | ||
const uint8_t* randomness); | ||
int Libcrux_Kyber768_Encapsulate(uint8_t* ct, | ||
uint8_t* ss, | ||
const uint8_t* pk, | ||
const uint8_t* randomness); | ||
int Libcrux_Kyber768_Decapsulate(uint8_t* ss, | ||
const uint8_t* ct, | ||
const uint8_t* sk); | ||
|
||
#if defined(__cplusplus) | ||
} | ||
#endif | ||
|
||
#define __Libcrux_Kem_Kyber_Kyber768_H_DEFINED | ||
#endif |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this used anywhere where we want libcrux on?
I don't think we want libcrux here just yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just added it there so that it's tested on some of the CI jobs that run this script, but I can remove it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If they go through, leave it. But if it makes problems, drop it.