Panic freedom with F* #133
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -21,16 +21,14 @@ libcrux-kem = {version = "0.0.2-alpha.1", features = ["pre-verification", "kyber | |||
| libcrux = { version = "0.0.2-alpha.1", features = [ | |||
| "rand", | |||
| ]} | |||
| hax-lib-macros = { git = "https://github.com/hacspec/hax", optional = true } | |||
| hax-lib = { git = "https://github.com/hacspec/hax" } | |||
| hax-lib = { git = "https://github.com/hacspec/hax/", branch= "pq11-fstar-libs" } | |||
There was a problem hiding this comment.
Let's remember to update this before merging.
src/tls13cert.rs
Outdated
| let mut u32word = [U8(0); 4]; | ||
| u32word[0..len].copy_from_slice(&b[offset..offset + len]); | ||
| Ok(u32_from_be_bytes(u32word).declassify() as usize >> ((4 - len) * 8)) | ||
| if b.len() >= offset + len { |
There was a problem hiding this comment.
I'm not sure if this is how it's used. This requires the caller to pass in only the exact slice that's read. I don't think that's how this should be defined.
| if b[offset].declassify() & 0x80u8 == 0u8 { | ||
| Ok((b[offset].declassify() & 0x7fu8) as usize) | ||
| } else { | ||
| if b.len() > offset { |
There was a problem hiding this comment.
Since we can use early returns. We should that in checks like these.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses [...] described in issue #.
Type of change
Motivation and Context
This PR adds panic freedom proofs (and relevant annotations) to the core protocol code.
Changes
TODO
Checklist
Fixes #