Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Autostart for DE following the freedesktop standard #80
Feature: Autostart for DE following the freedesktop standard #80
Changes from 1 commit
f2881b8
c8956e2
6ae79bb
2c0f834
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ensure the file ends with a single newline character.
The file should end with a single newline character.
Committable suggestion
Tools
Markdownlint
Remove trailing spaces.
There is a trailing space at the end of the line.
Committable suggestion
Tools
Markdownlint
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add logging for exceptions in
enable
method.While the method correctly handles
IOException
by throwingToggleAutoStartFailedException
, consider logging the exception details for better debugging.Committable suggestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add logging for exceptions in
disable
method.While the method correctly handles
IOException
by throwingToggleAutoStartFailedException
, consider logging the exception details for better debugging.Committable suggestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Class name should be consistent.
The class name
FreeDesktopAutoStartIT
should be consistent with the service class nameFreedesktopAutoStartService
.Committable suggestion