Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Externalize dependency-check #202

Merged
merged 2 commits into from
Jan 17, 2024

Conversation

JaniruTEC
Copy link
Contributor

@JaniruTEC JaniruTEC commented Jan 15, 2024

This PR moves the dependency-check to the skymatic/workflows project, namely run-dependency-check.yml

Also see: cryptomator/cryptolib#45

Current workflow SHA at time of PR: skymatic/workflows@c83f5bb

Summary by CodeRabbit

  • Refactor
    • Enhanced dependency check workflow with external configuration for improved maintainability and security.

@JaniruTEC JaniruTEC requested a review from infeo January 15, 2024 15:42
Copy link

coderabbitai bot commented Jan 15, 2024

Walkthrough

The dependency-check.yml file has undergone a significant refactoring, replacing the entire job definition with a single usage of an external workflow file run-dependency-check.yml from the skymatic/workflows repository. The new usage includes configuration for the operating system, Java distribution, Java version, and secrets for NVD API key and Slack webhook URL.

Changes

File Summary
.github/workflows/dependency-check.yml Refactored to use run-dependency-check.yml from skymatic/workflows with added configuration for OS, Java distribution/version, and secrets for NVD API and Slack.

Poem

🐰
"In the burrow of code, we hop to and fro,
Refactoring workflows, with a seamless flow.
Secrets tucked in, and dependencies checked,
A new chapter begins, with old complexities wrecked."
🎉

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@JaniruTEC
Copy link
Contributor Author

@coderabbitai review

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 1

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 7a64b4d and a6e69c9.
Files selected for processing (1)
  • .github/workflows/dependency-check.yml (1 hunks)
Additional comments: 1
.github/workflows/dependency-check.yml (1)
  • 13-20: The refactoring of the dependency-check.yml to use the external workflow run-dependency-check.yml from the skymatic/workflows repository is noted. The configuration parameters for the operating system, Java distribution, Java version, and secrets are correctly set up for the external workflow.

.github/workflows/dependency-check.yml Outdated Show resolved Hide resolved
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between a6e69c9 and dc0f07f.
Files selected for processing (1)
  • .github/workflows/dependency-check.yml (1 hunks)
Additional comments: 1
.github/workflows/dependency-check.yml (1)
  • 13-20: The external workflow reference and its configuration parameters appear to be correctly set up. However, ensure that the referenced commit v1 in the skymatic/workflows repository is the correct and intended version. Additionally, verify that the secrets NVD_API_KEY and SLACK_WEBHOOK_URL are properly configured in the repository's secrets to avoid runtime errors.

@JaniruTEC JaniruTEC merged commit ca43931 into develop Jan 17, 2024
6 checks passed
@JaniruTEC JaniruTEC deleted the refactoring/centralize-dependency-check branch January 17, 2024 17:28
JaniruTEC added a commit to cryptomator/integrations-win that referenced this pull request Jan 17, 2024
JaniruTEC added a commit to cryptomator/cryptomator that referenced this pull request Feb 1, 2024
JaniruTEC added a commit to cryptomator/cryptolib that referenced this pull request Feb 1, 2024
JaniruTEC added a commit to cryptomator/cryptomator that referenced this pull request Feb 6, 2024
overheadhunter added a commit to cryptomator/cryptolib that referenced this pull request Feb 9, 2024
#46)

* Changed version specifier for dependency-check

See: cryptomator/cryptofs#202 (comment)

* Updated JDK for dependency-check to 21

See: 5b2a228

---------

Co-authored-by: Sebastian Stenzel <[email protected]>
@infeo infeo added this to the 2.6.9 milestone Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants