-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Externalize dependency-check #202
Conversation
WalkthroughThe Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
@coderabbitai review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 1
Configuration used: CodeRabbit UI
Files selected for processing (1)
- .github/workflows/dependency-check.yml (1 hunks)
Additional comments: 1
.github/workflows/dependency-check.yml (1)
- 13-20: The refactoring of the
dependency-check.yml
to use the external workflowrun-dependency-check.yml
from theskymatic/workflows
repository is noted. The configuration parameters for the operating system, Java distribution, Java version, and secrets are correctly set up for the external workflow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- .github/workflows/dependency-check.yml (1 hunks)
Additional comments: 1
.github/workflows/dependency-check.yml (1)
- 13-20: The external workflow reference and its configuration parameters appear to be correctly set up. However, ensure that the referenced commit
v1
in theskymatic/workflows
repository is the correct and intended version. Additionally, verify that the secretsNVD_API_KEY
andSLACK_WEBHOOK_URL
are properly configured in the repository's secrets to avoid runtime errors.
#46) * Changed version specifier for dependency-check See: cryptomator/cryptofs#202 (comment) * Updated JDK for dependency-check to 21 See: 5b2a228 --------- Co-authored-by: Sebastian Stenzel <[email protected]>
This PR moves the dependency-check to the skymatic/workflows project, namely run-dependency-check.yml
Also see: cryptomator/cryptolib#45
Current workflow SHA at time of PR: skymatic/workflows@c83f5bb
Summary by CodeRabbit