Add a build based on CMake. #44
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
May 29, 2014 09:25
…mmands. When OTR session is initiated by sending ?OTR? message, Unknown command errors are printed on Irssi status because only the first line gets sent as PRIVMSG and the human-readable HTML-formattad instruction message gets spit out as raw commands to the IRC server. This patch works around the problem by converting any line break characters (not allowed by IRC protocol) into spaces, thus also avoiding possible security issues with any other unexpected output from libotr even if this particular message string is fixed (like I intend to do in my next patch).
…ith a description customized for IRC and irssi-otr.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does not remove autotools, one can use either build system but CMake works better for me (in particular when Irssi is installed in /usr/local). For removal of autotools and updated installation documentation, use my other branch cmake_only.