-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor to simpler JS #55
Open
coolaj86
wants to merge
22
commits into
cryptocoinjs:master
Choose a base branch
from
dashhive:ref-types
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f: make Prettier
coolaj86
changed the title
chore: add types and minor changes for type checking
Refactor to simpler JS
Jan 26, 2023
coolaj86
force-pushed
the
ref-types
branch
2 times, most recently
from
February 3, 2023 05:50
6aaefa7
to
61630a8
Compare
coolaj86
force-pushed
the
ref-types
branch
2 times, most recently
from
February 3, 2023 09:27
316d8ae
to
e2ca7c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in preparation for a larger refactor to update to modern, cross-platform
async
WebCrypto, Uint8Array, nobleSecp256k1, etc.getXyz()
s)assert
safe-buffer
assert(x, msg)
toif (!x) { throw new Error(msg) }
to satisfytsc
s style of nullish checking.I actually meant to PR this onto my own fork, but... I think it could serve well here too for a v3.
The individual commits are very atomic as to be easy to read and reason about.