-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem: rocksdb 8.0 is not used #940
Conversation
LGTM, is any feature Cronos need from Rocksdb v8 or just for following up on the latest Rocksdb release? |
just following up, not sure if the new option |
Solution: - fix build issue in grocksdb - update dependencies - enable OptimizeFiltersForMemory
Codecov Report
@@ Coverage Diff @@
## main #940 +/- ##
===========================================
+ Coverage 21.49% 46.70% +25.20%
===========================================
Files 47 81 +34
Lines 2996 7235 +4239
===========================================
+ Hits 644 3379 +2735
- Misses 2289 3497 +1208
- Partials 63 359 +296
|
* Problem: rocksdb 8.0 is not used Solution: - fix build issue in grocksdb - update dependencies - enable OptimizeFiltersForMemory * fix resolve * rocksdb 8.1.1 * fix resolve * changelog * install golangci-lint separately * fix workflow * fix deps * fix unittest workflow * fix workflow * fix unittest workflow --------- Signed-off-by: yihuang <[email protected]> Co-authored-by: mmsqe <[email protected]>
* Problem: rocksdb 8.0 is not used Solution: - fix build issue in grocksdb - update dependencies - enable OptimizeFiltersForMemory * fix resolve * rocksdb 8.1.1 * fix resolve * changelog * install golangci-lint separately * fix workflow * fix deps * fix unittest workflow * fix workflow * fix unittest workflow --------- Signed-off-by: yihuang <[email protected]> Co-authored-by: mmsqe <[email protected]>
Solution:
👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻
PR Checklist:
make
)make test
)go fmt
)golangci-lint run
)go list -json -m all | nancy sleuth
)Thank you for your code, it's appreciated! :)