Problem: no packet info for indexed field in ibc relayer event #1662
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1662 +/- ##
==========================================
+ Coverage 34.91% 35.01% +0.09%
==========================================
Files 123 123
Lines 11811 11778 -33
==========================================
Hits 4124 4124
+ Misses 7273 7240 -33
Partials 414 414
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| for k, v := range replaceAttrs { | ||
| attrs[k] = attrs[v] | ||
| } |
Check warning
Code scanning / CodeQL
Iteration over map Warning
yihuang
requested review from
JayT106 and
leejw51crypto
and removed request for
a team
WalkthroughThe pull request includes updates to the Changes
Possibly related PRs
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 4
🧹 Outside diff range and nitpick comments (7)
x/cronos/events/types/types.go (1)
4-7: LGTM! Consider adding documentation.The new constants follow consistent naming patterns and effectively address the missing packet information issue for IBC relayer events. The implementation aligns well with the existing codebase structure.
Consider adding a comment block above the const block to document the purpose of these event attributes, particularly explaining their role in IBC packet handling. This would help future maintainers understand the context better.
package types +// Event types and attribute keys for IBC packet handling events. +// These constants are used to identify and track packet information +// in the context of Inter-Blockchain Communication (IBC) relayer events. const ( EventTypeSubmitMsgsResult = "submit_msgs_result" AttributeKeySeq = "seq" AttributeKeySrcPortInfo = "packet_src_port_info" AttributeKeySrcChannelInfo = "packet_src_channel_info" )x/cronos/events/event.go (1)
71-73: Add test coverage for attribute replacement logic.While the map iteration is safe here (order-independence), the new attribute replacement logic needs test coverage to ensure reliability.
Would you like me to help generate test cases for the attribute replacement functionality? Consider cases like:
- Basic attribute replacement
- Non-existent source attributes
- Multiple replacements
🧰 Tools
🪛 GitHub Check: codecov/patch
[warning] 71-73: x/cronos/events/event.go#L71-L73
Added lines #L71 - L73 were not covered by tests🪛 GitHub Check: CodeQL
[warning] 71-73: Iteration over map
Iteration over map may be a possible source of non-determinismx/cronos/events/events.go (1)
64-76: Consider documenting the attribute replacement pattern.The new attribute replacement mechanism is a flexible solution that could be valuable for other event types. Consider:
- Adding documentation explaining when and how to use this pattern
- Creating a shared constant file for common replacement mappings if this pattern expands to other event types
🧰 Tools
🪛 GitHub Check: codecov/patch
[warning] 64-68: x/cronos/events/events.go#L64-L68
Added lines #L64 - L68 were not covered by testsCHANGELOG.md (1)
21-21: Consider adding more details to the changelog entry.While the entry correctly documents the improvement, it could be more specific about what packet information was added for better clarity.
Consider expanding the entry to:
-* [#1662](https://github.com/crypto-org-chain/cronos/pull/1662) Emit more packet info for ibc relayer event. +* [#1662](https://github.com/crypto-org-chain/cronos/pull/1662) Emit more packet info (source port and channel) for ibc relayer event.x/cronos/events/bindings/cosmos/precompile/relayer/i_relayer_module.abigen.go (3)
Line range hint
1581-1621: Consider adding tests for the updatedIbcTransferevent handlingThe
RelayerModuleIbcTransferstruct and associated functions have been modified but lack test coverage. Implementing tests will ensure functionality works as intended.Would you like assistance in creating tests for this updated code?
🧰 Tools
🪛 GitHub Check: codecov/patch
[warning] 1589-1589: x/cronos/events/bindings/cosmos/precompile/relayer/i_relayer_module.abigen.go#L1589
Added line #L1589 was not covered by tests
Line range hint
1748-1774: Consider adding tests forFilterRecvPacketandWatchRecvPacketfunctionsThese functions have been updated to accommodate new parameters but are not covered by tests. Adding tests will validate the new logic.
Would you like assistance in generating tests for these functions?
🧰 Tools
🪛 GitHub Check: codecov/patch
[warning] 1774-1774: x/cronos/events/bindings/cosmos/precompile/relayer/i_relayer_module.abigen.go#L1774
Added line #L1774 was not covered by tests
Line range hint
2048-2087: Consider adding tests forTimeoutPacketevent and associated functionsThe
RelayerModuleTimeoutPacketstruct and related functions have been updated. Tests should be added to ensure the reliability of these changes.Would you like assistance in creating tests for this code?
🧰 Tools
🪛 GitHub Check: codecov/patch
[warning] 2062-2062: x/cronos/events/bindings/cosmos/precompile/relayer/i_relayer_module.abigen.go#L2062
Added line #L2062 was not covered by tests
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (8)
- CHANGELOG.md (1 hunks)
- integration_tests/test_ibc_rly.py (6 hunks)
- x/cronos/events/bindings/cosmos/lib/cosmos_types.abigen.go (1 hunks)
- x/cronos/events/bindings/cosmos/precompile/relayer/i_relayer_module.abigen.go (32 hunks)
- x/cronos/events/bindings/src/Relayer.sol (1 hunks)
- x/cronos/events/event.go (1 hunks)
- x/cronos/events/events.go (2 hunks)
- x/cronos/events/types/types.go (1 hunks)
🧰 Additional context used
🪛 GitHub Check: codecov/patch
x/cronos/events/bindings/cosmos/precompile/relayer/i_relayer_module.abigen.go
[warning] 279-279: x/cronos/events/bindings/cosmos/precompile/relayer/i_relayer_module.abigen.go#L279
Added line #L279 was not covered by tests
[warning] 304-304: x/cronos/events/bindings/cosmos/precompile/relayer/i_relayer_module.abigen.go#L304
Added line #L304 was not covered by tests
[warning] 1152-1152: x/cronos/events/bindings/cosmos/precompile/relayer/i_relayer_module.abigen.go#L1152
Added line #L1152 was not covered by tests
[warning] 1154-1154: x/cronos/events/bindings/cosmos/precompile/relayer/i_relayer_module.abigen.go#L1154
Added line #L1154 was not covered by tests
[warning] 1164-1164: x/cronos/events/bindings/cosmos/precompile/relayer/i_relayer_module.abigen.go#L1164
Added line #L1164 was not covered by tests
[warning] 1166-1166: x/cronos/events/bindings/cosmos/precompile/relayer/i_relayer_module.abigen.go#L1166
Added line #L1166 was not covered by tests
[warning] 1287-1287: x/cronos/events/bindings/cosmos/precompile/relayer/i_relayer_module.abigen.go#L1287
Added line #L1287 was not covered by tests
[warning] 1294-1294: x/cronos/events/bindings/cosmos/precompile/relayer/i_relayer_module.abigen.go#L1294
Added line #L1294 was not covered by tests
[warning] 1304-1304: x/cronos/events/bindings/cosmos/precompile/relayer/i_relayer_module.abigen.go#L1304
Added line #L1304 was not covered by tests
[warning] 1311-1311: x/cronos/events/bindings/cosmos/precompile/relayer/i_relayer_module.abigen.go#L1311
Added line #L1311 was not covered by tests
[warning] 1434-1434: x/cronos/events/bindings/cosmos/precompile/relayer/i_relayer_module.abigen.go#L1434
Added line #L1434 was not covered by tests
[warning] 1445-1445: x/cronos/events/bindings/cosmos/precompile/relayer/i_relayer_module.abigen.go#L1445
Added line #L1445 was not covered by tests
[warning] 1455-1455: x/cronos/events/bindings/cosmos/precompile/relayer/i_relayer_module.abigen.go#L1455
Added line #L1455 was not covered by tests
[warning] 1466-1466: x/cronos/events/bindings/cosmos/precompile/relayer/i_relayer_module.abigen.go#L1466
Added line #L1466 was not covered by tests
[warning] 1589-1589: x/cronos/events/bindings/cosmos/precompile/relayer/i_relayer_module.abigen.go#L1589
Added line #L1589 was not covered by tests
[warning] 1600-1600: x/cronos/events/bindings/cosmos/precompile/relayer/i_relayer_module.abigen.go#L1600
Added line #L1600 was not covered by tests
[warning] 1610-1610: x/cronos/events/bindings/cosmos/precompile/relayer/i_relayer_module.abigen.go#L1610
Added line #L1610 was not covered by tests
[warning] 1621-1621: x/cronos/events/bindings/cosmos/precompile/relayer/i_relayer_module.abigen.go#L1621
Added line #L1621 was not covered by tests
[warning] 1749-1749: x/cronos/events/bindings/cosmos/precompile/relayer/i_relayer_module.abigen.go#L1749
Added line #L1749 was not covered by tests
[warning] 1774-1774: x/cronos/events/bindings/cosmos/precompile/relayer/i_relayer_module.abigen.go#L1774
Added line #L1774 was not covered by tests
[warning] 1911-1911: x/cronos/events/bindings/cosmos/precompile/relayer/i_relayer_module.abigen.go#L1911
Added line #L1911 was not covered by tests
[warning] 1918-1918: x/cronos/events/bindings/cosmos/precompile/relayer/i_relayer_module.abigen.go#L1918
Added line #L1918 was not covered by tests
[warning] 1928-1928: x/cronos/events/bindings/cosmos/precompile/relayer/i_relayer_module.abigen.go#L1928
Added line #L1928 was not covered by tests
[warning] 1935-1935: x/cronos/events/bindings/cosmos/precompile/relayer/i_relayer_module.abigen.go#L1935
Added line #L1935 was not covered by tests
[warning] 2062-2062: x/cronos/events/bindings/cosmos/precompile/relayer/i_relayer_module.abigen.go#L2062
Added line #L2062 was not covered by tests
[warning] 2087-2087: x/cronos/events/bindings/cosmos/precompile/relayer/i_relayer_module.abigen.go#L2087
Added line #L2087 was not covered by tests
[warning] 2384-2384: x/cronos/events/bindings/cosmos/precompile/relayer/i_relayer_module.abigen.go#L2384
Added line #L2384 was not covered by tests
[warning] 2409-2409: x/cronos/events/bindings/cosmos/precompile/relayer/i_relayer_module.abigen.go#L2409
Added line #L2409 was not covered by testsx/cronos/events/event.go
[warning] 71-73: x/cronos/events/event.go#L71-L73
Added lines #L71 - L73 were not covered by testsx/cronos/events/events.go
[warning] 64-68: x/cronos/events/events.go#L64-L68
Added lines #L64 - L68 were not covered by tests
🪛 GitHub Check: CodeQL
x/cronos/events/event.go
[warning] 71-73: Iteration over map
Iteration over map may be a possible source of non-determinism
🔇 Additional comments (27)
x/cronos/events/bindings/src/Relayer.sol (5)
13-13: Improved type safety for packet sequence numbers.The change from
stringtouint256forpacketSequenceis a good improvement as it:
- Provides better type safety for sequence numbers
- Reduces gas costs compared to string storage
- Enables numeric comparisons and arithmetic operations
Also applies to: 24-24, 35-35, 45-45
57-57: Appropriate removal of string indexing.Removing the
indexedkeyword from string parameters (refundDenom,denom) is beneficial because:
- String indexing requires keccak256 hashing, which increases gas costs
- The full string value is still available in the event data
- Consistent with best practices for handling denomination strings
Also applies to: 63-63, 69-69
73-73: Consistent event parameter indexing.The removal of
indexedfrom string parameters inDenominationTraceandDistributeFeeevents maintains consistency with other similar changes in the interface.Also applies to: 77-77
13-77: Verify event changes in dependent systems.The changes improve the IBC relayer events by adding detailed packet information and optimizing parameter types. However, these changes might affect systems that consume these events.
#!/bin/bash # Look for event consumers that might need updates rg -l "RecvPacket|WriteAcknowledgement|AcknowledgePacket|TimeoutPacket" | grep -v "Relayer.sol"Ensure that:
- Event consumers are updated to handle the new uint256 packet sequence
- Systems processing these events can handle the additional info fields
- Event indexing services are updated to reflect the removed string indexing
16-17: Consider adding maximum length for info fields.The new
packetSrcPortInfoandpacketSrcChannelInfostring fields could benefit from length constraints to prevent excessive gas costs.Consider:
- Adding validation in the implementation to enforce reasonable maximum lengths
- Documenting the expected format and size limits in comments
Also applies to: 27-28, 38-39, 48-49
x/cronos/events/event.go (1)
65-65: LGTM: Parameter addition aligns with PR objective.The new
replaceAttrsparameter enables flexible attribute mapping, which addresses the missing packet info issue.Let's verify the parameter usage across the codebase:
✅ Verification successful
Let me try a different approach to verify the usage of ConvertEvent across the codebase.
This will help us:
- Find all occurrences of ConvertEvent with surrounding context
- Locate all event-related files that might contain the implementation or usage
Based on the search results, I can now provide a final response:
Parameter addition requires no further updates in the codebase
The verification shows that the
ConvertEventmethod is used in two places:
RelayerConvertEventwhich correctly passes thereplaceAttrsparameter with the required channel mappingsIcaConvertEventwhich passes an empty mapmap[string]string{}as expectedThe implementation is consistent across all usages and no additional updates are needed.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Search for ConvertEvent calls to ensure they're updated with the new parameter ast-grep --pattern 'ConvertEvent($$$)'Length of output: 40
Script:
#!/bin/bash # Search for ConvertEvent using ripgrep for a broader search rg "ConvertEvent" -A 2 -B 2 # Also search for files containing "event" in their name to ensure we don't miss any implementations fd "event" --type fLength of output: 2122
x/cronos/events/events.go (2)
76-76: LGTM: Empty map parameter is appropriate for ICA events.The addition of an empty map parameter maintains API consistency while correctly indicating that ICA events don't require attribute replacement.
28-32: Sequence type conversion change looks good, but needs verification.The change from
ReturnStringAsIstoConvertUint64forAttributeKeySequenceis a good improvement for type safety. The new port info mappings are also correctly implemented.Let's verify the sequence type usage in the codebase:
x/cronos/events/bindings/cosmos/lib/cosmos_types.abigen.go (2)
41-41: Verify compatibility with Solidity version upgrade.The bytecode indicates a Solidity version upgrade from 0.8.25 to 0.8.28. While this is a minor version change, please verify:
- The new version is compatible with all dependent contracts
- No breaking changes are introduced in the version upgrade
#!/bin/bash # Description: Check for potential version compatibility issues # Find all Solidity files and their pragma versions fd -e sol | xargs rg "pragma solidity" # Find any version constraints in configuration files fd "package.json|package-lock.json|yarn.lock" | xargs rg "solc|solidity"
41-41: Verify source contract compilation.The bytecode update indicates a recompilation of the source Solidity contract. Since this is an auto-generated file, please ensure:
- The source contract was compiled with the correct settings
- The bindings were generated using the standard toolchain
integration_tests/test_ibc_rly.py (8)
96-96: LGTM: Direct fee value assignment improves transparencyThe removal of keccak hashing for the fee value makes the logs more readable and debugging easier.
104-104: LGTM: Direct denomination value improves token trackingThe removal of keccak hashing for the denomination value enhances log readability and token tracking capabilities.
126-130: LGTM: Enhanced packet information improves observabilityThe changes improve the packet information by:
- Using direct sequence values instead of hashes
- Adding human-readable source port and channel information
These improvements make debugging and monitoring IBC packets more effective.
146-150: LGTM: Consistent packet information handlingThe changes maintain consistency with the
recv_packetfunction, ensuring uniform packet information handling across different packet types.
159-159: LGTM: Improved denomination tracingDirect denomination value assignment enhances the clarity of denomination tracing.
165-169: LGTM: Consistent acknowledgment packet handlingThe changes align with other packet handling functions, maintaining consistency in how packet information is handled across the codebase.
218-218: LGTM: Proper type handling for packet sequencesConverting packet sequence to integer ensures correct type handling for comparisons and filtering operations.
229-229: Verify handling of large sequence numbersThe 64-character hex format is correct for EVM log topics, but let's verify the handling of large sequence numbers.
CHANGELOG.md (1)
Line range hint
1-1183: LGTM!The changelog is well-structured with clear categorization of changes and consistent formatting.
🧰 Tools
🪛 Markdownlint
23-23: null
Emphasis used instead of a heading(MD036, no-emphasis-as-heading)
x/cronos/events/bindings/cosmos/precompile/relayer/i_relayer_module.abigen.go (8)
47-47: ABI updates correctly reflect contract changesThe ABI definition has been updated to include new fields and data types, aligning with the modifications in the smart contract. The changes appear consistent and accurate.
1163-1166: UpdatedWatchDenominationTracefunctionThe
WatchDenominationTracefunction has been updated to reflect the changes in event parameters. Ensure that any subscriptions are updated accordingly.🧰 Tools
🪛 GitHub Check: codecov/patch
[warning] 1164-1164: x/cronos/events/bindings/cosmos/precompile/relayer/i_relayer_module.abigen.go#L1164
Added line #L1164 was not covered by tests
[warning] 1166-1166: x/cronos/events/bindings/cosmos/precompile/relayer/i_relayer_module.abigen.go#L1166
Added line #L1166 was not covered by tests
Line range hint
1426-1466: Update inRelayerModuleFungibleTokenPacketevent handlingThe
RelayerModuleFungibleTokenPacketstruct now includes updated data types forDenomandAmount. The changes align with the ABI updates.🧰 Tools
🪛 GitHub Check: codecov/patch
[warning] 1434-1434: x/cronos/events/bindings/cosmos/precompile/relayer/i_relayer_module.abigen.go#L1434
Added line #L1434 was not covered by tests
1734-1744: Updates toRelayerModuleRecvPacketevent structThe struct now includes new fields such as
PacketSrcPortInfoandPacketSrcChannelInfo. These additions appear consistent with the ABI changes.
Line range hint
1903-1935: Updates toRelayerModuleTimeoutevent handlingThe
RefundDenomfield type has been changed tostring, aligning with the ABI. The updates are appropriate and consistent.🧰 Tools
🪛 GitHub Check: codecov/patch
[warning] 1911-1911: x/cronos/events/bindings/cosmos/precompile/relayer/i_relayer_module.abigen.go#L1911
Added line #L1911 was not covered by tests
[warning] 1918-1918: x/cronos/events/bindings/cosmos/precompile/relayer/i_relayer_module.abigen.go#L1918
Added line #L1918 was not covered by tests
301-304: UpdatedWatchAcknowledgePacketfunction parametersThe parameters of the
WatchAcknowledgePacketfunction have been updated to match the changes in the event definition. Ensure consistency across the codebase.You can run the following script to verify that all usages are updated:
#!/bin/bash # Description: Find all usages of WatchAcknowledgePacket to verify parameters. rg 'WatchAcknowledgePacket\('🧰 Tools
🪛 GitHub Check: codecov/patch
[warning] 304-304: x/cronos/events/bindings/cosmos/precompile/relayer/i_relayer_module.abigen.go#L304
Added line #L304 was not covered by tests
Line range hint
2369-2409: Updates toWriteAcknowledgementevent handlingNew fields have been added to the
RelayerModuleWriteAcknowledgementstruct, and function parameters have been updated accordingly. The changes are consistent with the ABI.Please verify that all usages of these functions are updated:
✅ Verification successful
Let me search with a more comprehensive pattern to find all related usages.
Based on the search results, I can now provide the final response:
WriteAcknowledgementevent handling is correctly implementedThe changes to the
WriteAcknowledgementevent handling are consistent across the codebase:
- The event is defined in the Solidity contract (
Relayer.sol)- The Go bindings in
i_relayer_module.abigen.gocorrectly implement all the necessary structs and methods- The only usage outside the bindings is in
integration_tests/test_ibc_rly.pywhich only references the event name in a list🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Check for usages of WriteAcknowledgement functions. rg 'WriteAcknowledgement\('Length of output: 352
Script:
#!/bin/bash # Search for any mentions of WriteAcknowledgement in the codebase rg -i "writeacknowledgement"Length of output: 14352
🧰 Tools
🪛 GitHub Check: codecov/patch
[warning] 2384-2384: x/cronos/events/bindings/cosmos/precompile/relayer/i_relayer_module.abigen.go#L2384
Added line #L2384 was not covered by tests
276-279: UpdatedFilterAcknowledgePacketfunction parametersThe parameters of the
FilterAcknowledgePacketfunction have been updated to reflect the new indexed fields in the event. Ensure that all call sites are updated accordingly.You can run the following script to verify that all call sites are updated:
🧰 Tools
🪛 GitHub Check: codecov/patch
[warning] 279-279: x/cronos/events/bindings/cosmos/precompile/relayer/i_relayer_module.abigen.go#L279
Added line #L279 was not covered by tests
| replaceAttrs := map[string]string{ | ||
| cronoseventstypes.AttributeKeySrcPortInfo: channeltypes.AttributeKeySrcPort, | ||
| cronoseventstypes.AttributeKeySrcChannelInfo: channeltypes.AttributeKeySrcChannel, | ||
| } | ||
| return desc.ConvertEvent(event.Attributes, RelayerValueDecoders, replaceAttrs) |
There was a problem hiding this comment.
Add test coverage for the new attribute replacement logic.
The new attribute replacement logic is not covered by tests. Please add test cases to verify the correct mapping of AttributeKeySrcPortInfo and AttributeKeySrcChannelInfo.
Would you like me to help generate test cases? Here's a suggested test structure:
func TestRelayerConvertEvent_AttributeReplacement(t *testing.T) {
testCases := []struct {
name string
event sdk.Event
expected *ethtypes.Log
}{
{
name: "should replace port info attributes",
event: sdk.Event{
Type: "ibc_transfer",
Attributes: []sdk.Attribute{
{Key: cronoseventstypes.AttributeKeySrcPortInfo, Value: "transfer"},
{Key: cronoseventstypes.AttributeKeySrcChannelInfo, Value: "channel-0"},
},
},
// Add expected values
},
// Add more test cases
}
// Implement test logic
}🧰 Tools
🪛 GitHub Check: codecov/patch
[warning] 64-68: x/cronos/events/events.go#L64-L68
Added lines #L64 - L68 were not covered by tests
| PacketSequence *big.Int | ||
| PacketSrcPort common.Hash | ||
| PacketSrcChannel common.Hash | ||
| PacketSrcPortInfo string | ||
| PacketSrcChannelInfo string | ||
| PacketDstPort string | ||
| PacketDstChannel string | ||
| ConnectionId string | ||
| Raw types.Log // Blockchain specific contextual infos | ||
| } |
There was a problem hiding this comment.
Consider adding tests for the updated RelayerModuleAcknowledgePacket event struct
The RelayerModuleAcknowledgePacket struct has been updated with new fields and data types, but these changes are not currently covered by tests. Adding tests will ensure the correctness and reliability of the new functionality.
Would you like assistance in generating tests for this updated code?
| Denom string | ||
| Raw types.Log // Blockchain specific contextual infos | ||
| } | ||
|
|
||
| // FilterDenominationTrace is a free log retrieval operation binding the contract event 0x483180a024351f3ea4c4782eaadb34add715974648a3d47bbff4a7b76da20859. | ||
| // | ||
| // Solidity: event DenominationTrace(string indexed denom) | ||
| func (_RelayerModule *RelayerModuleFilterer) FilterDenominationTrace(opts *bind.FilterOpts, denom []string) (*RelayerModuleDenominationTraceIterator, error) { | ||
| // Solidity: event DenominationTrace(string denom) | ||
| func (_RelayerModule *RelayerModuleFilterer) FilterDenominationTrace(opts *bind.FilterOpts) (*RelayerModuleDenominationTraceIterator, error) { | ||
|
|
||
| var denomRule []interface{} | ||
| for _, denomItem := range denom { | ||
| denomRule = append(denomRule, denomItem) | ||
| } | ||
|
|
||
| logs, sub, err := _RelayerModule.contract.FilterLogs(opts, "DenominationTrace", denomRule) | ||
| logs, sub, err := _RelayerModule.contract.FilterLogs(opts, "DenominationTrace") |
There was a problem hiding this comment.
Consider adding tests for the updated DenominationTrace event handling
The RelayerModuleDenominationTrace struct and associated functions have been updated but are not currently covered by tests. Adding tests will enhance reliability.
Would you like assistance in generating tests for this code?
🧰 Tools
🪛 GitHub Check: codecov/patch
[warning] 1152-1152: x/cronos/events/bindings/cosmos/precompile/relayer/i_relayer_module.abigen.go#L1152
Added line #L1152 was not covered by tests
[warning] 1154-1154: x/cronos/events/bindings/cosmos/precompile/relayer/i_relayer_module.abigen.go#L1154
Added line #L1154 was not covered by tests
| Fee string | ||
| Raw types.Log // Blockchain specific contextual infos | ||
| } | ||
|
|
||
| // FilterDistributeFee is a free log retrieval operation binding the contract event 0x67e2bceb7881996b4bbddf9ab5d5c9bceb0ace3a06538b5e40be96094c4c9a72. | ||
| // | ||
| // Solidity: event DistributeFee(address indexed receiver, string indexed fee) | ||
| func (_RelayerModule *RelayerModuleFilterer) FilterDistributeFee(opts *bind.FilterOpts, receiver []common.Address, fee []string) (*RelayerModuleDistributeFeeIterator, error) { | ||
| // Solidity: event DistributeFee(address indexed receiver, string fee) | ||
| func (_RelayerModule *RelayerModuleFilterer) FilterDistributeFee(opts *bind.FilterOpts, receiver []common.Address) (*RelayerModuleDistributeFeeIterator, error) { | ||
|
|
||
| var receiverRule []interface{} | ||
| for _, receiverItem := range receiver { | ||
| receiverRule = append(receiverRule, receiverItem) | ||
| } | ||
| var feeRule []interface{} | ||
| for _, feeItem := range fee { | ||
| feeRule = append(feeRule, feeItem) | ||
| } | ||
|
|
||
| logs, sub, err := _RelayerModule.contract.FilterLogs(opts, "DistributeFee", receiverRule, feeRule) | ||
| logs, sub, err := _RelayerModule.contract.FilterLogs(opts, "DistributeFee", receiverRule) |
There was a problem hiding this comment.
Consider adding tests for the updated DistributeFee event handling
The RelayerModuleDistributeFee struct and associated functions have been updated but are not currently covered by tests. Adding tests will ensure the correctness of the new functionality.
Would you like assistance in generating tests for this code?
🧰 Tools
🪛 GitHub Check: codecov/patch
[warning] 1287-1287: x/cronos/events/bindings/cosmos/precompile/relayer/i_relayer_module.abigen.go#L1287
Added line #L1287 was not covered by tests
[warning] 1294-1294: x/cronos/events/bindings/cosmos/precompile/relayer/i_relayer_module.abigen.go#L1294
Added line #L1294 was not covered by tests
1ca4595
👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻
PR Checklist:
make)make test)go fmt)golangci-lint run)go list -json -m all | nancy sleuth)Thank you for your code, it's appreciated! :)
Summary by CodeRabbit
Release Notes
New Features
Improvements
uint256forpacketSequence, improving data handling.Bug Fixes
Documentation