Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: latest hermes is not used in integration tests #1143

Closed
wants to merge 2 commits into from

Conversation

mmsqe
Copy link
Collaborator

@mmsqe mmsqe commented Aug 25, 2023

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

nix/sources.json Outdated Show resolved Hide resolved
nix/hermes.nix Outdated Show resolved Hide resolved
@mmsqe mmsqe marked this pull request as ready for review August 25, 2023 04:18
@mmsqe mmsqe requested a review from a team as a code owner August 25, 2023 04:18
@mmsqe mmsqe requested review from calvinaco and thomas-nguy and removed request for a team August 25, 2023 04:18
@@ -1394,12 +1459,13 @@ tomlkit = "^0.7.0"
type = "git"
url = "https://github.com/crypto-com/pystarport.git"
reference = "main"
resolved_reference = "b2aa98544958811429948aff3ab4bb3881f56a1f"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mmsqe mmsqe marked this pull request as draft August 25, 2023 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant