Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: memiavl is not added to erc20 benchmark #1137

Merged
merged 2 commits into from
Aug 21, 2023

Conversation

yihuang
Copy link
Collaborator

@yihuang yihuang commented Aug 21, 2023

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

@yihuang yihuang requested a review from a team as a code owner August 21, 2023 06:17
@yihuang yihuang requested review from JayT106, thomas-nguy and mmsqe and removed request for a team August 21, 2023 06:17
@yihuang yihuang enabled auto-merge August 21, 2023 08:30
@yihuang yihuang added this pull request to the merge queue Aug 21, 2023
@codecov
Copy link

codecov bot commented Aug 21, 2023

Codecov Report

Merging #1137 (a9bb2f9) into main (115eed6) will increase coverage by 24.70%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #1137       +/-   ##
===========================================
+ Coverage   24.08%   48.78%   +24.70%     
===========================================
  Files          47       66       +19     
  Lines        2940     5864     +2924     
===========================================
+ Hits          708     2861     +2153     
- Misses       2162     2687      +525     
- Partials       70      316      +246     

see 70 files with indirect coverage changes

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 21, 2023
@yihuang yihuang added this pull request to the merge queue Aug 21, 2023
Merged via the queue into crypto-org-chain:main with commit 21ec1ad Aug 21, 2023
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants