Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: duplicate cache events are emitted #1102

Merged
merged 8 commits into from
Jul 17, 2023

Conversation

mmsqe
Copy link
Collaborator

@mmsqe mmsqe commented Jul 14, 2023

for more info, see https://github.com/cosmos/cosmos-sdk/pull/13063/files

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

@mmsqe mmsqe marked this pull request as ready for review July 15, 2023 01:37
@mmsqe mmsqe requested a review from a team as a code owner July 15, 2023 01:37
@mmsqe mmsqe requested review from yihuang and calvinaco and removed request for a team July 15, 2023 01:37
@mmsqe mmsqe added this pull request to the merge queue Jul 17, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 17, 2023
@yihuang yihuang added this pull request to the merge queue Jul 17, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 17, 2023
@yihuang yihuang enabled auto-merge July 17, 2023 03:57
@codecov
Copy link

codecov bot commented Jul 17, 2023

Codecov Report

Merging #1102 (3dc98c3) into main (0d27835) will increase coverage by 1.89%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1102      +/-   ##
==========================================
+ Coverage   46.47%   48.37%   +1.89%     
==========================================
  Files          81       65      -16     
  Lines        7236     5879    -1357     
==========================================
- Hits         3363     2844     -519     
+ Misses       3516     2721     -795     
+ Partials      357      314      -43     
Impacted Files Coverage Δ
x/cronos/keeper/gravity_hooks.go 0.00% <ø> (ø)
x/cronos/keeper/keeper.go 76.87% <ø> (-0.15%) ⬇️

... and 23 files with indirect coverage changes

@yihuang yihuang added this pull request to the merge queue Jul 17, 2023
Merged via the queue into crypto-org-chain:main with commit 7ee50bf Jul 17, 2023
24 checks passed
mmsqe added a commit to mmsqe/cronos that referenced this pull request Jul 18, 2023
* avoid emit duplicate events

for more info, see https://github.com/cosmos/cosmos-sdk/pull/13063/files

* test dup in ibc

* add change doc

* test dup in gravity

* pin nixpkgs flake

* pin to local nixpkgs

* pin to 23.05

* fix unit test

---------

Co-authored-by: HuangYi <[email protected]>
mmsqe added a commit that referenced this pull request Jul 18, 2023
* avoid emit duplicate events

for more info, see https://github.com/cosmos/cosmos-sdk/pull/13063/files

* test dup in ibc

* add change doc

* test dup in gravity

* pin nixpkgs flake

* pin to local nixpkgs

* pin to 23.05

* fix unit test

---------

Co-authored-by: HuangYi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants