-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem: duplicate cache events are emitted #1102
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmsqe
requested review from
yihuang and
calvinaco
and removed request for
a team
July 15, 2023 01:37
yihuang
reviewed
Jul 17, 2023
yihuang
approved these changes
Jul 17, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Jul 17, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Jul 17, 2023
Codecov Report
@@ Coverage Diff @@
## main #1102 +/- ##
==========================================
+ Coverage 46.47% 48.37% +1.89%
==========================================
Files 81 65 -16
Lines 7236 5879 -1357
==========================================
- Hits 3363 2844 -519
+ Misses 3516 2721 -795
+ Partials 357 314 -43
|
mmsqe
added a commit
to mmsqe/cronos
that referenced
this pull request
Jul 18, 2023
* avoid emit duplicate events for more info, see https://github.com/cosmos/cosmos-sdk/pull/13063/files * test dup in ibc * add change doc * test dup in gravity * pin nixpkgs flake * pin to local nixpkgs * pin to 23.05 * fix unit test --------- Co-authored-by: HuangYi <[email protected]>
mmsqe
added a commit
that referenced
this pull request
Jul 18, 2023
* avoid emit duplicate events for more info, see https://github.com/cosmos/cosmos-sdk/pull/13063/files * test dup in ibc * add change doc * test dup in gravity * pin nixpkgs flake * pin to local nixpkgs * pin to 23.05 * fix unit test --------- Co-authored-by: HuangYi <[email protected]>
13 tasks
This was referenced Apr 26, 2024
This was referenced Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for more info, see https://github.com/cosmos/cosmos-sdk/pull/13063/files
👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻
PR Checklist:
make
)make test
)go fmt
)golangci-lint run
)go list -json -m all | nancy sleuth
)Thank you for your code, it's appreciated! :)