-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Show bounty prize on cards #180
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Fixing a missing commit to bring deployment back to normal. |
The card looks like this now: But I found the spacing and order of components weird, so I tweaked it a bit: Here is the diff: diff --git a/frontend/src/app/explore/page.tsx b/frontend/src/app/explore/page.tsx
index d1da2fa..309118c 100644
--- a/frontend/src/app/explore/page.tsx
+++ b/frontend/src/app/explore/page.tsx
@@ -5,6 +5,7 @@ import {
Button,
Center,
Stack,
+ Space,
Image,
Card,
Flex,
@@ -55,18 +56,19 @@ const Bounty: FC<{
bountyStatus={bountyStatus}
/>
</Group>
- <Text>
- Total Prize:{" "}
- {formatErc20Amount(
- token,
- totalPrize,
- erc20Metadata,
- )}
- </Text>
</Stack>
<Text truncate="end" size="xs" c="dimmend">
{bounty.description}
</Text>
+ <Space h="sm" />
+ <Text ta="right">
+ Total Prize:{" "}
+ {formatErc20Amount(
+ token,
+ totalPrize,
+ erc20Metadata,
+ )}
+ </Text>
</Box>
</Card>
</Anchor> What do you think? |
I agree. Also, is the title truncated with ellipsis if it's too long, or does it break into several lines automatically?
The idea was to give a preview of what the bounty is about. But if you think it will not give any information to the user, we can remove it. |
It is truncated with ellipsis.
Ok. |
1b944e2
to
5fc4456
Compare
Hi @guidanoli , here comes a screenshot of the final result. What do you think? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good on my end
5fc4456
to
fe0020b
Compare
Closes #121