Fix build with for MSVC 17.10. #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crud89
added
Bug 🐞
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
MSVC 17.10 broke builds with earlier releases of vcpkg. This PR fixes those issues and thus implicitly raises some dependency versions. Most notably, glm has been pushed to version 1.0, which broke some samples. An appropriate fix is included in the release.
Related issues
As MSVC 17.10 contains a compiler fix required for #120, this PR is a prerequisite to finally merge it. Additionally, the latest version of vcpkg contains a port for DXC, which allows us to not depend on external DXC distributions (most notably we do no longer require future Windows packages to provide DXIL.dll). An additional branch for this change has been created and will be merged in a separate PR. This allows us to then merge #118.