Adding Visual Expectations for Plotting Functions #572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #572 +/- ##
==========================================
+ Coverage 82.04% 82.13% +0.08%
==========================================
Files 45 45
Lines 4222 4225 +3
==========================================
+ Hits 3464 3470 +6
+ Misses 758 755 -3
☔ View full report in Codecov by Sentry. |
|
Hah, great. I've been 'considering' this for ages. Thanks for taking the initiative! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @crsh,
It is still one of my aims to refactor the family of
apa_*plot()functions in the future. Actually, I already drafted a powerful approach, but the changes are so extensive that it is practically impossible to review these changes all at once and I also want to take some precautions not to break older code.Therefore, I thought it is wise to first add visual expectations (via the vdiffr package) before I start adding theses changes one by one.
This PR is intended to get github actions running, and to gain some experience with vdiffr. I will require your review as soon as I have the impression that we can add these tests to the main branch. In the meantime, any feedback on how to improve the testing pipeline is highly appreciated.