Skip to content

Commit

Permalink
Fixes failing Apple M1 tests on R-devel.
Browse files Browse the repository at this point in the history
  • Loading branch information
crsh committed Jul 11, 2022
1 parent 03156d9 commit 6f64628
Show file tree
Hide file tree
Showing 4 changed files with 24 additions and 23 deletions.
4 changes: 2 additions & 2 deletions DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
Package: papaja
Title: Prepare American Psychological Association Journal Articles with
R Markdown
Version: 0.1.0
Version: 0.1.1
Description: Tools to create dynamic, submission-ready manuscripts, which
conform to American Psychological Association manuscript guidelines. We
provide R Markdown document formats for manuscripts (PDF and Word) and
Expand All @@ -15,7 +15,7 @@ Authors@R: c(
, person("Joseph V.", "Casillas", email = "[email protected]", role = c("ctb"))
, person("Rudolf", "Siegel", email = "[email protected]", role = c("ctb"))
)
Date: 2022-06-22
Date: 2022-07-04
URL: https://github.com/crsh/papaja
BugReports: https://github.com/crsh/papaja/issues
Depends:
Expand Down
19 changes: 7 additions & 12 deletions cran-comments.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

- macOS 12.1, R 4.1.2 (local)
- macOS-latest, R-release (r-lib actions)
- Apple Silicon (M1), macOS 11.6 Big Sur, R-release (r-hub)
- Windows Server 2022, R-devel (win-builder)
- Windows Server 2008, R-release (win-builder)
- Windows-latest, R-release (r-lib actions)
Expand All @@ -18,14 +19,12 @@
* checking CRAN incoming feasibility ... NOTE
Maintainer: 'Frederik Aust <[email protected]>'

New submission

Found the following (possibly) invalid URLs:
URL: https://doi.org/10.1037/1082-989X.9.2.164
From: man/apa_print.glm.Rd
man/apa_print.list.Rd
Status: 403
Message: Forbidden
Status: 400
Message: Bad Request
URL: https://doi.org/10.1177/0013164406292030
From: man/apa_print.list.Rd
Status: 503
Expand All @@ -34,20 +33,16 @@ Found the following (possibly) invalid URLs:
From: man/apa_print.list.Rd
Status: 503
Message: Service Unavailable
URL: https://doi.org/10.18637/jss.v020.i08
From: man/apa_print.glm.Rd
man/apa_print.list.Rd
URL: https://pandoc.org/
From: man/papaja.Rd
README.md
Status: 221

## Comments

All DOIs/URLs are correct. Maybe the sites are blocking non-human traffic?

This is a resubmission. In response to the reviewer comments I have

- added missing value sections to .Rd files (sorry for overlooking these the during the first revision)

Thanks for the thorough review and constructive comments.
This is a resubmission, to address a Apple M1 issue (https://cran.r-project.org/web/checks/check_results_papaja.html)

## Downstream dependencies

Expand Down
6 changes: 5 additions & 1 deletion inst/NEWS.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
# papaja 0.1.1

- Maintenance update: Adjuted unit tests to avoid removal from CRAN

# papaja 0.1.0

Initial CRAN release
Expand Down Expand Up @@ -63,7 +67,7 @@ Initial CRAN release

### Template

- New author metadata field `role` automatically adds contributor ship roles (e.g. [CRedit](https://casrai.org/credit/)) to the author note. #375
- New author metadata field `role` automatically adds contributor ship roles (e.g. [CRedit](https://credit.niso.org/)) to the author note. #375
- `apa6_pdf()`
- Now relies on a Lua-filter to process metadata, which should resolve many encoding related problems (e.g., reported by @arcaldwell49, @dcbrh, and @DominiqueMakowski among others; #350, #357, #360)
- Numbering of title is now disabled when `numbersections: true`
Expand Down
18 changes: 10 additions & 8 deletions tests/testthat/test_custom_effect_sizes.R
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
test_that(
"Custom effect sizes for ANOVA"
, {
set.seed(49873)
ges <- getOption("papaja.estimate_anova")

# Treat as between-subjects design, use Type-1 sums of squares
Expand Down Expand Up @@ -41,14 +42,6 @@ test_that(
!!apa_with_df$estimate$N
, "$\\hat{\\eta}^2_G = .224$, 90\\% CI $[.017, .460]$"
)
expect_identical(
!!apa_with_df$estimate$P
, "$\\hat{\\eta}^2_G = .013$, 90\\% CI $[.000, .181]$"
)
expect_identical(
!!apa_with_df$estimate$N_P
, "$\\hat{\\eta}^2_G = .031$, 90\\% CI $[.000, .229]$"
)

expect_identical(
apa_with_function
Expand Down Expand Up @@ -113,6 +106,15 @@ test_that(
, regexp = "Cannot apply custom effect-size function to this class of object."
)

skip_on_cran()
expect_identical(
!!apa_with_df$estimate$P
, "$\\hat{\\eta}^2_G = .013$, 90\\% CI $[.000, .181]$"
)
expect_identical(
!!apa_with_df$estimate$N_P
, "$\\hat{\\eta}^2_G = .031$, 90\\% CI $[.000, .229]$"
)
}
)

Expand Down

0 comments on commit 6f64628

Please sign in to comment.