Fix more editor bugs

crschnick · Apr 2, 2021 · 5231b1c · 5231b1c
1 parent 2ac8397
commit 5231b1c
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 7 deletions.
diff --git a/app/src/main/java/com/crschnick/pdx_unlimiter/app/editor/EditorCollectorNode.java b/app/src/main/java/com/crschnick/pdx_unlimiter/app/editor/EditorCollectorNode.java
@@ -18,6 +18,19 @@ public EditorCollectorNode(EditorNode directParent, String keyName, int parentIn
         this.nodes = nodes;
     }
 
+    @Override
+    public void updateNodeAtIndex(Node replacementValue, String toInsertKeyName, int index) {
+        getRealParent().updateNodeAtIndex(replacementValue, keyName, firstNodeIndex + index);
+    }
+
+    @Override
+    public void replacePart(ArrayNode toInsert, int beginIndex, int length) {
+        getRealParent().replacePart(
+                ArrayNode.sameKeyArray(keyName, toInsert.getNodeArray()),
+                firstNodeIndex + beginIndex,
+                length);
+    }
+
     @Override
     public void delete() {
         getRealParent().replacePart(

diff --git a/app/src/main/java/com/crschnick/pdx_unlimiter/app/editor/EditorNode.java b/app/src/main/java/com/crschnick/pdx_unlimiter/app/editor/EditorNode.java
@@ -1,6 +1,7 @@
 package com.crschnick.pdx_unlimiter.app.editor;
 
 import com.crschnick.pdx_unlimiter.core.node.ArrayNode;
+import com.crschnick.pdx_unlimiter.core.node.Node;
 import com.crschnick.pdx_unlimiter.core.node.NodeMatcher;
 
 import java.util.ArrayList;
@@ -72,6 +73,10 @@ public static List<EditorNode> create(EditorNode parent, ArrayNode ar) {
         return result;
     }
 
+    public abstract void updateNodeAtIndex(Node replacementValue, String toInsertKeyName, int index);
+
+    public abstract void replacePart(ArrayNode toInsert, int beginIndex, int length);
+
     public abstract void delete();
 
     public abstract boolean filterKey(Predicate<String> filter);

diff --git a/app/src/main/java/com/crschnick/pdx_unlimiter/app/editor/EditorSimpleNode.java b/app/src/main/java/com/crschnick/pdx_unlimiter/app/editor/EditorSimpleNode.java
@@ -30,14 +30,14 @@ public void updateColor(Color c) {
         cn.set(newColorNode);
     }
 
-    private void updateParentNodeAtIndex(Node replacementValue, String toInsertKeyName, int index) {
+    public void updateNodeAtIndex(Node replacementValue, String toInsertKeyName, int index) {
         ArrayNode ar = (ArrayNode) backingNode;
 
         var replacement = toInsertKeyName != null ?
                 ArrayNode.singleKeyNode(toInsertKeyName, replacementValue) : ArrayNode.array(List.of(replacementValue));
         this.backingNode = ar.replacePart(replacement, index, 1);
         if (getDirectParent() != null) {
-            getRealParent().updateParentNodeAtIndex(this.backingNode, keyName, getKeyIndex());
+            getDirectParent().updateNodeAtIndex(this.backingNode, keyName, getKeyIndex());
         }
     }
 
@@ -47,14 +47,14 @@ public void replacePart(ArrayNode toInsert, int beginIndex, int length) {
 
         // Update parent node to reflect change
         if (getDirectParent() != null) {
-            getRealParent().updateParentNodeAtIndex(this.backingNode, keyName, getKeyIndex());
+            getDirectParent().updateNodeAtIndex(this.backingNode, keyName, getKeyIndex());
         }
     }
 
     @Override
     public void delete() {
         if (getDirectParent() != null) {
-            getRealParent().replacePart(ArrayNode.emptyArray(), getKeyIndex(), 1);
+            getDirectParent().replacePart(ArrayNode.emptyArray(), getKeyIndex(), 1);
         }
     }
 
@@ -108,9 +108,7 @@ public void update(ArrayNode newNode) {
 
             // Update parent node to reflect change
             if (getDirectParent() != null) {
-                var replacement = getKeyName().map(k -> ArrayNode.singleKeyNode(k, this.backingNode))
-                        .orElse(ArrayNode.array(this.backingNode.getNodeArray()));
-                getRealParent().replacePart(replacement, getKeyIndex(), 1);
+                getDirectParent().updateNodeAtIndex(this.backingNode, keyName, getKeyIndex());
             }
         } else {
             var nodeToUse = newNode.getNodeArray().get(0);