Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: creds as args via cmd #885

Merged
merged 2 commits into from
Jan 16, 2025
Merged

fix: creds as args via cmd #885

merged 2 commits into from
Jan 16, 2025

Conversation

yevheniyJ
Copy link
Collaborator

No description provided.

@yevheniyJ yevheniyJ linked an issue Jan 11, 2025 that may be closed by this pull request
Copy link

codecov bot commented Jan 11, 2025

Codecov Report

Attention: Patch coverage is 87.50000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 65.97%. Comparing base (5331d62) to head (fd5b34c).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...a/com/crowdin/cli/commands/actions/CliActions.java 75.00% 1 Missing ⚠️
...li/commands/picocli/DistributionAddSubcommand.java 0.00% 1 Missing ⚠️
...ommands/picocli/DistributionReleaseSubcommand.java 0.00% 1 Missing ⚠️
...i/commands/picocli/ScreenshotUploadSubcommand.java 0.00% 1 Missing ⚠️
...om/crowdin/cli/properties/PropertiesWithFiles.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #885      +/-   ##
============================================
+ Coverage     65.76%   65.97%   +0.21%     
- Complexity     1565     1570       +5     
============================================
  Files           237      237              
  Lines          6355     6356       +1     
  Branches        948      948              
============================================
+ Hits           4179     4193      +14     
+ Misses         1631     1619      -12     
+ Partials        545      544       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrii-bodnar andrii-bodnar merged commit 4d48fc6 into main Jan 16, 2025
15 checks passed
@andrii-bodnar andrii-bodnar deleted the arg-based-creds branch January 16, 2025 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

distribution release fails due to "Configuration file doesn't exists"
2 participants