Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: If-None-Match header reset in Translation API #204

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

bhdnb
Copy link
Collaborator

@bhdnb bhdnb commented Jan 15, 2025

No description provided.

@bhdnb bhdnb changed the title fix: If-None-Match header reset in Translation API [closes #195] fix: If-None-Match header reset in Translation API Jan 15, 2025
@bhdnb bhdnb force-pushed the translation-api-update branch from 58173df to 956eeeb Compare January 15, 2025 16:24
Copy link

codecov bot commented Jan 15, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.49%. Comparing base (3ae9950) to head (956eeeb).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
src/CrowdinApiClient/Api/AbstractApi.php 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #204      +/-   ##
============================================
+ Coverage     89.37%   89.49%   +0.13%     
  Complexity     1294     1294              
============================================
  Files           119      119              
  Lines          3393     3394       +1     
============================================
+ Hits           3032     3037       +5     
+ Misses          361      357       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrii-bodnar andrii-bodnar merged commit fd3c939 into master Jan 16, 2025
13 checks passed
@andrii-bodnar andrii-bodnar deleted the translation-api-update branch January 16, 2025 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

buildProjectFileTranslation doesn't reset If-None-Match header on consecutive calls
2 participants