feat: Add isPublic property to ReportSettings #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abuna1985
force-pushed
the
310-report-settings-template-is-public
branch
from
b5dd95c to
273b3ce
Compare
abuna1985
force-pushed
the
310-report-settings-template-is-public
branch
from
273b3ce to
6c74834
Compare
|
Apologies. I added parenthesis after |
abuna1985
changed the title
abuna1985
changed the title
|
Ugh. Also on the PR title. My bad. It has been updated |
Codecov Report
@@ Coverage Diff @@
## master #313 +/- ##
=======================================
Coverage 92.10% 92.10%
=======================================
Files 34 34
Lines 1379 1379
Branches 118 118
=======================================
Hits 1270 1270
Misses 75 75
Partials 34 34
|
andrii-bodnar
added
the
hacktoberfest
andrii-bodnar
approved these changes
Oct 20, 2023
kodiakhq bot
referenced
this pull request
in weareinreach/TransMascFutures
Oct 24, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@crowdin/crowdin-api-client](https://togithub.com/crowdin/crowdin-api-client-js) | [`1.25.0` -> `1.25.1`](https://renovatebot.com/diffs/npm/@crowdin%2fcrowdin-api-client/1.25.0/1.25.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@types/react](https://togithub.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/react) ([source](https://togithub.com/DefinitelyTyped/DefinitelyTyped)) | [`18.2.30` -> `18.2.31`](https://renovatebot.com/diffs/npm/@types%2freact/18.2.30/18.2.31) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@typescript-eslint/eslint-plugin](https://togithub.com/typescript-eslint/typescript-eslint) | [`6.8.0` -> `6.9.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2feslint-plugin/6.8.0/6.9.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@typescript-eslint/parser](https://togithub.com/typescript-eslint/typescript-eslint) | [`6.8.0` -> `6.9.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2fparser/6.8.0/6.9.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [eslint](https://eslint.org) ([source](https://togithub.com/eslint/eslint)) | [`8.51.0` -> `8.52.0`](https://renovatebot.com/diffs/npm/eslint/8.51.0/8.52.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [eslint-plugin-import](https://togithub.com/import-js/eslint-plugin-import) | [`2.28.1` -> `2.29.0`](https://renovatebot.com/diffs/npm/eslint-plugin-import/2.28.1/2.29.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [superjson](https://togithub.com/blitz-js/superjson) | [`2.0.0` -> `2.1.0`](https://renovatebot.com/diffs/npm/superjson/2.0.0/2.1.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>crowdin/crowdin-api-client-js (@​crowdin/crowdin-api-client)</summary> ### [`v1.25.1`](https://togithub.com/crowdin/crowdin-api-client-js/releases/tag/1.25.1) [Compare Source](https://togithub.com/crowdin/crowdin-api-client-js/compare/1.25.0...1.25.1) #### What's Changed - feat: Add `isPublic` property to `ReportSettings` by [@​abuna1985](https://togithub.com/abuna1985) in [https://github.com/crowdin/crowdin-api-client-js/pull/313](https://togithub.com/crowdin/crowdin-api-client-js/pull/313) - feat: file context by [@​yevheniyJ](https://togithub.com/yevheniyJ) in [https://github.com/crowdin/crowdin-api-client-js/pull/314](https://togithub.com/crowdin/crowdin-api-client-js/pull/314) - build(deps-dev): bump typedoc from 0.25.1 to 0.25.2 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/crowdin/crowdin-api-client-js/pull/307](https://togithub.com/crowdin/crowdin-api-client-js/pull/307) #### New Contributors - [@​abuna1985](https://togithub.com/abuna1985) made their first contribution in [https://github.com/crowdin/crowdin-api-client-js/pull/313](https://togithub.com/crowdin/crowdin-api-client-js/pull/313) **Full Changelog**: crowdin/crowdin-api-client-js@1.25.0...1.25.1 </details> <details> <summary>typescript-eslint/typescript-eslint (@​typescript-eslint/eslint-plugin)</summary> ### [`v6.9.0`](https://togithub.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#690-2023-10-23) [Compare Source](https://togithub.com/typescript-eslint/typescript-eslint/compare/v6.8.0...v6.9.0) ##### Bug Fixes - **eslint-plugin:** \[no-confusing-void-expression] handle unfixable cases ([#​7674](https://togithub.com/typescript-eslint/typescript-eslint/issues/7674)) ([7e52f27](https://togithub.com/typescript-eslint/typescript-eslint/commit/7e52f276ed5b8b2c0b76be02cb2e8a77892c10f2)) - **eslint-plugin:** \[no-unsafe-return] allow returning anything if explicitly returning any ([#​7708](https://togithub.com/typescript-eslint/typescript-eslint/issues/7708)) ([c6124b2](https://togithub.com/typescript-eslint/typescript-eslint/commit/c6124b2c93a53f11471cce8054388dec7a58f90b)) ##### Features - **eslint-plugin:** \[max-params] don't count `this: void` parameter ([#​7696](https://togithub.com/typescript-eslint/typescript-eslint/issues/7696)) ([6398d3f](https://togithub.com/typescript-eslint/typescript-eslint/commit/6398d3fd0a576d8cdc957ec1b57929acacc60ba0)), closes [#​7538](https://togithub.com/typescript-eslint/typescript-eslint/issues/7538) - **eslint-plugin:** \[naming-convention] add support for default and namespace imports ([#​7269](https://togithub.com/typescript-eslint/typescript-eslint/issues/7269)) ([bb15aae](https://togithub.com/typescript-eslint/typescript-eslint/commit/bb15aae877ae260f59aa5e6cfc338b1eefc6d85c)) - **eslint-plugin:** \[no-restricted-imports] support import = require ([#​7709](https://togithub.com/typescript-eslint/typescript-eslint/issues/7709)) ([4c8edcf](https://togithub.com/typescript-eslint/typescript-eslint/commit/4c8edcfb7d3cc02d07d2329c87da4377c1cbf969)) - **eslint-plugin:** \[no-unsafe-enum-comparison] add switch suggestion ([#​7691](https://togithub.com/typescript-eslint/typescript-eslint/issues/7691)) ([53d5263](https://togithub.com/typescript-eslint/typescript-eslint/commit/53d5263cee8e0b5ddc5de3321d27559c196e5b58)), closes [#​7643](https://togithub.com/typescript-eslint/typescript-eslint/issues/7643) - **eslint-plugin:** \[prefer-readonly] private fields support ([#​7686](https://togithub.com/typescript-eslint/typescript-eslint/issues/7686)) ([0e875bf](https://togithub.com/typescript-eslint/typescript-eslint/commit/0e875bf77a9d94dc74924245fabc36c0ae780977)) You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website. </details> <details> <summary>typescript-eslint/typescript-eslint (@​typescript-eslint/parser)</summary> ### [`v6.9.0`](https://togithub.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#690-2023-10-23) [Compare Source](https://togithub.com/typescript-eslint/typescript-eslint/compare/v6.8.0...v6.9.0) **Note:** Version bump only for package [@​typescript-eslint/parser](https://togithub.com/typescript-eslint/parser) You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website. </details> <details> <summary>eslint/eslint (eslint)</summary> ### [`v8.52.0`](https://togithub.com/eslint/eslint/releases/tag/v8.52.0) [Compare Source](https://togithub.com/eslint/eslint/compare/v8.51.0...v8.52.0) #### Features - [`70648ee`](https://togithub.com/eslint/eslint/commit/70648ee49c07f7b533d09f6bf8a5291e5a5a8601) feat: report-unused-disable-directive to report unused eslint-enable ([#​17611](https://togithub.com/eslint/eslint/issues/17611)) (Yosuke Ota) #### Bug Fixes - [`5de9637`](https://togithub.com/eslint/eslint/commit/5de9637fc925729a83d5a5e9e868a41792a184e3) fix: Ensure shared references in rule configs are separated ([#​17666](https://togithub.com/eslint/eslint/issues/17666)) (Nicholas C. Zakas) - [`dcfe573`](https://togithub.com/eslint/eslint/commit/dcfe5739c374c9d7ed21f14027870ec0fd453661) fix: add preceding semicolon in suggestions of `no-object-constructor` ([#​17649](https://togithub.com/eslint/eslint/issues/17649)) (Francesco Trotta) #### Documentation - [`476d58a`](https://togithub.com/eslint/eslint/commit/476d58a584d5d2db003c4c22ffee90e63566164d) docs: Add note about invalid CLI flags when using flat config. ([#​17664](https://togithub.com/eslint/eslint/issues/17664)) (Nicholas C. Zakas) - [`660ed3a`](https://togithub.com/eslint/eslint/commit/660ed3afd128ad529234a855345629982caf1bc7) docs: Plugin flat config migration guide ([#​17640](https://togithub.com/eslint/eslint/issues/17640)) (Nicholas C. Zakas) - [`a58aa20`](https://togithub.com/eslint/eslint/commit/a58aa200fccedae7e2e9b6129246f2cedab14f8d) docs: fix examples for several rules ([#​17645](https://togithub.com/eslint/eslint/issues/17645)) (Milos Djermanovic) - [`179929b`](https://togithub.com/eslint/eslint/commit/179929bd46892f18f2aef0c159d5cc361cb69987) docs: Remove trailing newline from the code of Playground links ([#​17641](https://togithub.com/eslint/eslint/issues/17641)) (Francesco Trotta) - [`f8e5c30`](https://togithub.com/eslint/eslint/commit/f8e5c30636450d4a8baf51f0e227685e6d77ac64) docs: Update README (GitHub Actions Bot) - [`b7ef2f3`](https://togithub.com/eslint/eslint/commit/b7ef2f34fe12b68a366e1b4bf5f64d7332c6e72e) docs: Enable pretty code formatter output ([#​17635](https://togithub.com/eslint/eslint/issues/17635)) (Nicholas C. Zakas) - [`0bcb9a8`](https://togithub.com/eslint/eslint/commit/0bcb9a8db608a3d0bd2645f99e0707b9a9bbaaf0) docs: Fix syntax errors in rule examples ([#​17633](https://togithub.com/eslint/eslint/issues/17633)) (Francesco Trotta) - [`61b9083`](https://togithub.com/eslint/eslint/commit/61b90839633ef300ac7707a651f65f532e65f42d) docs: Make no-continue example code work ([#​17643](https://togithub.com/eslint/eslint/issues/17643)) (Zhongyuan Zhou) - [`9fafe45`](https://togithub.com/eslint/eslint/commit/9fafe450c31ed9b6bdd9dcd6c115255943b8c1c2) docs: upgrade to 11ty 2.0 ([#​17632](https://togithub.com/eslint/eslint/issues/17632)) (Percy Ma) - [`ff8e4bf`](https://togithub.com/eslint/eslint/commit/ff8e4bf327b5c92b0623b0fc5f8f101954f785db) docs: Update README (GitHub Actions Bot) - [`fab249a`](https://togithub.com/eslint/eslint/commit/fab249ae6addac2ee18cd81cee80916010bb469e) docs: Update README (GitHub Actions Bot) - [`392305b`](https://togithub.com/eslint/eslint/commit/392305bf4797e3ebc696dfca48bd874741fca845) docs: Update `no-irregular-whitespace` and fix examples ([#​17626](https://togithub.com/eslint/eslint/issues/17626)) (Francesco Trotta) - [`6b8acfb`](https://togithub.com/eslint/eslint/commit/6b8acfb770589f3941df41c3910d3b8ffc3e1e45) docs: Add real whitespace to `no-trailing-spaces` examples ([#​17630](https://togithub.com/eslint/eslint/issues/17630)) (Francesco Trotta) - [`1000187`](https://togithub.com/eslint/eslint/commit/1000187e00949332babcee4d37d46c96a6a554a8) docs: Fix examples in `unicode-bom` ([#​17631](https://togithub.com/eslint/eslint/issues/17631)) (Francesco Trotta) - [`000290c`](https://togithub.com/eslint/eslint/commit/000290c4c923cc1473e21b4bdbdc0c42765ef7dd) docs: Update README (GitHub Actions Bot) #### Chores - [`6d1f0c2`](https://togithub.com/eslint/eslint/commit/6d1f0c2da0309c06c21149b8d71a8f439a70d7e8) chore: upgrade [@​eslint/js](https://togithub.com/eslint/js)[@​8](https://togithub.com/8).52.0 ([#​17671](https://togithub.com/eslint/eslint/issues/17671)) (Milos Djermanovic) - [`d63d4fe`](https://togithub.com/eslint/eslint/commit/d63d4fe0942e6747ab60e758aa36076f43041a30) chore: package.json update for [@​eslint/js](https://togithub.com/eslint/js) release (ESLint Jenkins) - [`f30cefe`](https://togithub.com/eslint/eslint/commit/f30cefee6bda2789ede18e1664b84c2638ea1bb5) test: fix FlatESLint tests for caching ([#​17658](https://togithub.com/eslint/eslint/issues/17658)) (Milos Djermanovic) - [`ef650cb`](https://togithub.com/eslint/eslint/commit/ef650cb612510bcfa1379c1f0af56dd563b3a705) test: update tests for no-promise-executor-return ([#​17661](https://togithub.com/eslint/eslint/issues/17661)) (Milos Djermanovic) </details> <details> <summary>import-js/eslint-plugin-import (eslint-plugin-import)</summary> ### [`v2.29.0`](https://togithub.com/import-js/eslint-plugin-import/blob/HEAD/CHANGELOG.md#2290---2023-10-22) [Compare Source](https://togithub.com/import-js/eslint-plugin-import/compare/v2.28.1...v2.29.0) ##### Added - TypeScript config: add .cts and .mts extensions (\[[#​2851](https://togithub.com/import-js/eslint-plugin-import/issues/2851)], thanks \[[@​Zamiell](https://togithub.com/Zamiell)]) - \[`newline-after-import`]: new option `exactCount` and docs update (\[[#​1933](https://togithub.com/import-js/eslint-plugin-import/issues/1933)], thanks \[[@​anikethsaha](https://togithub.com/anikethsaha)] and \[[@​reosarevok](https://togithub.com/reosarevok)]) - \[`newline-after-import`]: fix `exactCount` with `considerComments` false positive, when there is a leading comment (\[[#​2884](https://togithub.com/import-js/eslint-plugin-import/issues/2884)], thanks \[[@​kinland](https://togithub.com/kinland)]) </details> <details> <summary>blitz-js/superjson (superjson)</summary> ### [`v2.1.0`](https://togithub.com/blitz-js/superjson/releases/tag/v2.1.0) [Compare Source](https://togithub.com/blitz-js/superjson/compare/v2.0.0...v2.1.0) ##### What's Changed - Strip constructor, prototype, and **proto** properties in the serialize step by [@​tmcw](https://togithub.com/tmcw) in [https://github.com/blitz-js/superjson/pull/267](https://togithub.com/blitz-js/superjson/pull/267) - docs: add tmcw as a contributor for bug, and code by [@​allcontributors](https://togithub.com/allcontributors) in [https://github.com/blitz-js/superjson/pull/269](https://togithub.com/blitz-js/superjson/pull/269) - add "main" to package.json by [@​kidqueb](https://togithub.com/kidqueb) in [https://github.com/blitz-js/superjson/pull/264](https://togithub.com/blitz-js/superjson/pull/264) - docs: add kidqueb as a contributor for bug, and code by [@​allcontributors](https://togithub.com/allcontributors) in [https://github.com/blitz-js/superjson/pull/270](https://togithub.com/blitz-js/superjson/pull/270) ##### New Contributors - [@​tmcw](https://togithub.com/tmcw) made their first contribution in [https://github.com/blitz-js/superjson/pull/267](https://togithub.com/blitz-js/superjson/pull/267) - [@​kidqueb](https://togithub.com/kidqueb) made their first contribution in [https://github.com/blitz-js/superjson/pull/264](https://togithub.com/blitz-js/superjson/pull/264) **Full Changelog**: flightcontrolhq/superjson@v2.0.0...v2.1.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/weareinreach/GLAAD). PR-URL: #221 Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #310
isPublicproperty to the ReportSettings InterfaceisPublicproperty in the ReportSettings interfaceCompleted Pull Request Checklist
Click here to see my failing test screenshot
Here is a screenshot of my failed test after adding the isPublic property to the ReportSettings interface
Click here to see my passing tests screenshot
Here is a screenshot of my passing test after adding the isPublic property to the ReportSettings test
Click here to see isPublic property in the docs after full implementation
Here is a screenshot of my local docs with the isPublic property visible in the ReportSettings section