Allow specifying a list of Java extra parameters #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahadas
added a commit
to ahadas/mucommander
that referenced
this pull request
Sep 26, 2024
this dmg does not include JRE but rather uses the JRE that is available on the machine. to achieve this, we added gradle-macappbundle back with the changes in: crotwell/gradle-macappbundle#76
ahadas
added a commit
to ahadas/mucommander
that referenced
this pull request
Sep 26, 2024
this dmg does not include JRE but rather uses the JRE that is available on the machine. to achieve this, we added gradle-macappbundle back with the changes in: crotwell/gradle-macappbundle#76
ahadas
added a commit
to ahadas/mucommander
that referenced
this pull request
Sep 26, 2024
this dmg does not include JRE but rather uses the JRE that is available on the machine. to achieve this, we added gradle-macappbundle back with the changes in: crotwell/gradle-macappbundle#76
ahadas
added a commit
to ahadas/mucommander
that referenced
this pull request
Sep 26, 2024
this dmg does not include JRE but rather uses the JRE that is available on the machine. to achieve this, we added gradle-macappbundle back with the changes in: crotwell/gradle-macappbundle#76
ahadas
added a commit
to ahadas/mucommander
that referenced
this pull request
Sep 26, 2024
this dmg does not include JRE but rather uses the JRE that is available on the machine. to achieve this, we added gradle-macappbundle back with the changes in: crotwell/gradle-macappbundle#76
ahadas
added a commit
to mucommander/mucommander
that referenced
this pull request
Sep 26, 2024
this dmg does not include JRE but rather uses the JRE that is available on the machine. to achieve this, we added gradle-macappbundle back with the changes in: crotwell/gradle-macappbundle#76
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we had a map (javaExtras) for parameters that are passed to the JVM along with "-D options".
That doesn't allow us to specify parameters that repeat several times with different values, e.g.,
--add-exports X --add-exports Y.This PR adds another list that we can use to specify such parameters to the JVM.
In addition, Gradle wrapper was upgraded to version 8.8 (by
gradlew wrapper --gradle-version 8.8)