Fixes for xpkg init generation recommendations and CI workflow for uppercase github org names
#92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yury Tsarev <[email protected]>
Otherwise it will fail for GitHub orgs with uppercase chars in theri name with the error similar to the one below ``` crossplane: error: failed to parse package tag "xpkg.upbound.io/UpboundCare/function-azresourcegraph:v0.0.0-20241211161841-62aad247be2c": repository can only contain the characters `abcdefghijklmnopqrstuvwxyz0123456789_-./`: UpboundCare/function-azresourcegraph ``` Signed-off-by: Yury Tsarev <[email protected]>
turkenh
approved these changes
Dec 12, 2024
phisco
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
go generate->go generate ./...in NOTES and readme. It is visible right aftercrossplane xpkg initso it is important to provide correct CLI instructions to the userAvoid failure in CI workflow by handling cases for GitHub organizations with uppercase characters in their names, e.g.
UpboundCare. Before this change you would hit the failure similar to the one belowI have: