Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add extra-resources to cli docs #818

Merged
merged 2 commits into from
Oct 15, 2024

Conversation

stevendborrelli
Copy link
Contributor

Add the extra-resources option to the CLI command for 1.17 and master.

Fixes #817

Vale

$ vale --config="utils/vale/.vale.ini" content/master/cli/command-reference.md     
✔ 0 errors, 0 warnings and 0 suggestions in 1 file.
$ vale --config="utils/vale/.vale.ini" content/v1.17/cli/command-reference.md
✔ 0 errors, 0 warnings and 0 suggestions in 1 file.

Signed-off-by: Steven Borrelli <[email protected]>
Signed-off-by: Steven Borrelli <[email protected]>
Copy link

netlify bot commented Sep 27, 2024

Deploy Preview for crossplane ready!

Name Link
🔨 Latest commit 2d631c6
🔍 Latest deploy log https://app.netlify.com/sites/crossplane/deploys/66f6e3f56a835800096be56b
😎 Deploy Preview https://deploy-preview-818--crossplane.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 87 (🟢 up 3 from production)
Accessibility: 90 (🔴 down 2 from production)
Best Practices: 83 (no change from production)
SEO: 93 (no change from production)
PWA: 70 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@phisco phisco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏 thanks! not a 100% sure about all the white spaces and new lines, but I guess they won't hurt

@stevendborrelli
Copy link
Contributor Author

Regarding the white spaces, my markdown linter flags them as issues, for example https://github.com/updownpress/markdown-lint/blob/master/rules/009-no-trailing-spaces.md.

@phisco phisco merged commit e0b13c5 into crossplane:master Oct 15, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extra-resources flag not available in render
2 participants