-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: broken link #782
fix: broken link #782
Conversation
✅ Deploy Preview for crossplane ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome, thanks for taking the time to make this update @joachimprinzbach! It's functionally correct, but just one request for you to make this same change to the v1.16 directory too 🙇♂️
@@ -332,7 +332,7 @@ Below are vendors providing conformant Crossplane distributions. | |||
#### Upbound | |||
Upbound, the founders of Crossplane, maintains a free and open source | |||
distribution of Crossplane called | |||
[Universal Crossplane](https://www.upbound.io/products/universal-crossplane) | |||
[Universal Crossplane](https://www.upbound.io/product/universal-crossplane) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this change looks correct to me now and is working on the preview site. nice find!
can you also make this same change to https://github.com/crossplane/docs/blob/master/content/v1.16/software/install.md, so folks will see your update right away on the latest (i.e. v1.16) version of the site? 😁
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Included the fix in all the versions
I think your commit may also need a DCO sign-off, which can be easily updated with these instructions: https://github.com/crossplane/crossplane/tree/master/contributing#certificate-of-origin |
Signed-off-by: Joachim Prinzbach <[email protected]>
Yeah thanks for pointing out - commit is signed now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @joachimprinzbach, thank you for backporting this fix to previous versions as well! 💪
No description provided.