-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document Usage replayDeletion #728
Conversation
✅ Deploy Preview for crossplane ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
5e0bf0e
to
4279d34
Compare
Signed-off-by: Hasan Turken <[email protected]>
4279d34
to
3e02cbb
Compare
|
||
By default, the deletion of a `Usage` resource doesn't trigger the deletion of | ||
the resource in use even if there were deletion attempts blocked by the `Usage`. | ||
Replaying the blocked deletion is possible by setting the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is "replaying" the way to get kubernetes to try and delete the resource again after the usage
is removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Usage protects by blocking the deletion of the used resource as long as there are using resources.
Unfortunately, Kubernetes garbage collection backoffs up to 15 mins and there seems to be no way to reset this backoff.
"replaying" is sending a delete request to the used resource when the Usage is gone iff there was a blocked delete request.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd suggest an edit to be more explicit about that here, something like
Use {{}}replayDeletion: true{{}} to immediately create send a deletion request to Kubernetes instead of waiting for the Kubernetes backoff.
Feel free to reword, I'd just make it more obvious that "doing this makes deletion happen faster"
Documenting the configuration introduced by crossplane/crossplane#5394