Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Incorrect Package Tags In 'AWS Quickstart Part 2' #725

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

ihcsim
Copy link
Contributor

@ihcsim ihcsim commented Mar 5, 2024

This PR adds the missing v prefix to the tags of the S3 and DynamoDB packages used in the 'AWS Quickstart Part 2' documentation.

Fixes #724.

Copy link

netlify bot commented Mar 5, 2024

Deploy Preview for crossplane ready!

Name Link
🔨 Latest commit e44b78b
🔍 Latest deploy log https://app.netlify.com/sites/crossplane/deploys/65e754a16ffd3d0008f1acb2
😎 Deploy Preview https://deploy-preview-725--crossplane.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 91 (🟢 up 5 from production)
Accessibility: 88 (🔴 down 3 from production)
Best Practices: 83 (no change from production)
SEO: 93 (no change from production)
PWA: 70 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@plumbis
Copy link
Collaborator

plumbis commented Mar 5, 2024

Good catch and thank you for the fix! Can you add the same changes to content/v1.15/getting-started/provider-aws-part-2.md

@ihcsim ihcsim force-pushed the web-bug-aws-quickstart-part2 branch from 27c26fc to e44b78b Compare March 5, 2024 17:21
@ihcsim
Copy link
Contributor Author

ihcsim commented Mar 5, 2024

@plumbis Done. PTAL.

@plumbis plumbis merged commit 937b498 into crossplane:master Mar 5, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Web Bug] - AWS Quickstart Part 2: Incorrect Package Tags
2 participants