Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't say composition revisions are beta #710

Merged
merged 1 commit into from
Feb 15, 2024

Conversation

negz
Copy link
Member

@negz negz commented Feb 14, 2024

Relates to #709. I don't think it's a complete 'fix'.

Revisions became GA in v1.12 per crossplane/crossplane#3715. I think there's more to do to integrate them into the main docs flow as a GA feature, but at minimum let's stop actively saying they're beta.

When the feature became GA, we:

  • Made it impossible to disable the feature using the flag.
  • Hid the feature flag from the help output.
  • Log a warning that the flag will be removed if it is passed.

crossplane/crossplane#3715

Revisions became GA in v1.12. I think there's more to do to integrate
them into the main docs flow as a GA feature, but at minimum let's stop
actively saying they're beta.

When the feature became GA, we:

* Made it impossible to disable the feature using the flag.
* Hid the feature flag from the help output.
* Log a warning that the flag will be removed if it is passed.

Signed-off-by: Nic Cope <[email protected]>
Copy link

netlify bot commented Feb 14, 2024

Deploy Preview for crossplane ready!

Name Link
🔨 Latest commit 5af06a8
🔍 Latest deploy log https://app.netlify.com/sites/crossplane/deploys/65cd45b0f2581100089c0f5a
😎 Deploy Preview https://deploy-preview-710--crossplane.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 79 (🔴 down 10 from production)
Accessibility: 88 (🔴 down 3 from production)
Best Practices: 83 (no change from production)
SEO: 93 (no change from production)
PWA: 70 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@negz
Copy link
Member Author

negz commented Feb 14, 2024

Looks like all the Vale errors pertain to content I didn't touch. In the interest of time I'd prefer not to address them in this PR.

@plumbis plumbis merged commit 47d4e9c into crossplane:master Feb 15, 2024
6 of 7 checks passed
@negz negz deleted the generally-available branch February 15, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants