-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v1.15 Docs #701
v1.15 Docs #701
Conversation
✅ Deploy Preview for crossplane ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@@ -244,9 +244,9 @@ at the table below. | |||
{{< table caption="Feature flags" >}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i would expect this page in master
to be updated with the same content that is in the v1.15 version. e.g. this block in the 1.15 page about changing the default registry:
- https://deploy-preview-701--crossplane.netlify.app/v1.15/software/install/#change-the-default-package-registry
- https://github.com/crossplane/docs/pull/701/files#diff-69a7157c116add5db8956596b933da896f47aafaaf82f6f562e6abd1a409e1f2R264-R272
Does not seem to be in this master version of the page, e.g. https://deploy-preview-701--crossplane.netlify.app/master/software/install/#change-the-default-package-registry doesn't exist.
Is that expected for you? and if not, is there possibly more missing content that is in 1.15 but not showing up in master?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm planning on syncing the master
folder from 1.15
once all the content is in. right now half the stuff is in master and half in 1.15.
Because of the way some 1.14 fixes went into master but not 1.14, some in 1.14 and not master and most new content in master, but not the stuff I'm writing it's a bit of a mess.
Consider the 1.15 directory as the source of truth right now.
[Upbound Marketplace](https://marketplace.upbound.io) at `xpkg.upbound.io` | ||
instead of DockerHub. | ||
|
||
Change the default registry location during the Crossplane install with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you also want to include content around how to clean-up/fix the scenario where folks miss the notification about the default registry changing and they upgrade to v1.15 without taking that into account?
e.g. the very raw content from https://gist.github.com/jbw976/793210f26f2dfbb458a41d5dc437ce7e?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I want to bring this into a new "upgrade" chapter that I'm going to write shortly after release, since the context for this is only related to upgrades and not new installs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good - a fast follow on that would be very appreciated, because I know over the next few days we'll have at least some folks that need to get sorted out with their packages and registry default 😞 - so being able to efficiently support them (e.g. a consistent docs spot to point them at) will be really helpful! 🙇♂️
Signed-off-by: Pete Lumbis <[email protected]>
Signed-off-by: Pete Lumbis <[email protected]>
Signed-off-by: Pete Lumbis <[email protected]>
Signed-off-by: Pete Lumbis <[email protected]>
Signed-off-by: Pete Lumbis <[email protected]>
Signed-off-by: Pete Lumbis <[email protected]>
Signed-off-by: Pete Lumbis <[email protected]>
Signed-off-by: Pete Lumbis <[email protected]>
Signed-off-by: Pete Lumbis <[email protected]>
Signed-off-by: Pete Lumbis <[email protected]>
Signed-off-by: Pete Lumbis <[email protected]>
Signed-off-by: Pete Lumbis <[email protected]>
Signed-off-by: Pete Lumbis <[email protected]>
Signed-off-by: Pete Lumbis <[email protected]>
Signed-off-by: Pete Lumbis <[email protected]>
Signed-off-by: Pete Lumbis <[email protected]>
Signed-off-by: Pete Lumbis <[email protected]>
Signed-off-by: Pete Lumbis <[email protected]>
Signed-off-by: Pete Lumbis <[email protected]>
Signed-off-by: Pete Lumbis <[email protected]>
Signed-off-by: Pete Lumbis <[email protected]>
Signed-off-by: Pete Lumbis <[email protected]>
Signed-off-by: Pete Lumbis <[email protected]>
Signed-off-by: Pete Lumbis <[email protected]>
Signed-off-by: Pete Lumbis <[email protected]>
Signed-off-by: Pete Lumbis <[email protected]>
Docs for new v1.15 release.
Signed-off-by: Pete Lumbis [email protected]