Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve documentation of defaultCompositeDeletePolicy #686

Merged
merged 4 commits into from
Jan 29, 2024

Conversation

bobh66
Copy link
Collaborator

@bobh66 bobh66 commented Jan 27, 2024

Updated the description of the defaultCompositeDeletePolicy property as a result of crossplane/crossplane#5301

Also updated .gitignore to include the .idea directory created by PyCharm

Copy link

netlify bot commented Jan 27, 2024

Deploy Preview for crossplane ready!

Name Link
🔨 Latest commit 8600c8b
🔍 Latest deploy log https://app.netlify.com/sites/crossplane/deploys/65b7b8bc3397f9000836747c
😎 Deploy Preview https://deploy-preview-686--crossplane.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 91 (🟢 up 12 from production)
Accessibility: 88 (🔴 down 3 from production)
Best Practices: 83 (no change from production)
SEO: 93 (no change from production)
PWA: 70 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Signed-off-by: Bob Haddleton <[email protected]>
Signed-off-by: Bob Haddleton <[email protected]>
Copy link
Collaborator

@plumbis plumbis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a request to remove the use of etc

content/master/concepts/composite-resource-definitions.md Outdated Show resolved Hide resolved
content/v1.13/concepts/composite-resource-definitions.md Outdated Show resolved Hide resolved
content/v1.14/concepts/composite-resource-definitions.md Outdated Show resolved Hide resolved
@plumbis plumbis merged commit 653d7c6 into crossplane:master Jan 29, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants