-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Offline Provider Installation Documentation #628
Conversation
✅ Deploy Preview for crossplane ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: arielsepton <[email protected]>
It looks like you may have accidentally pulled in a lot of other commits for this PR. Can you rebase or open a new PR that only includes your intended changes? |
Signed-off-by: arielsepton <[email protected]>
Thanks for catching that @plumbis! I've fixed the issue |
up xpkg xp-extract xpkg.upbound.io/upbound/provider-aws:v0.44.0 | ||
mv out.gz "${CACHE_PATH}/provider-aws.gz" | ||
chmod 644 "${CACHE_PATH}/provider-aws.gz" | ||
docker tag xpkg.upbound.io/upbound/provider-aws:v0.44.0 provider-aws |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
up xpkg xp-extract
is a hidden command (the equiv is an alpha command) is it possible to use the crossplane
CLI to do this?
Does the package have to be extracted?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bump
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the package does need to be extracted.
For Crossplane offline installation, with –set packageCache.pvc=<pvc name>
option, The extracted packages must be placed in the directory where the PVC is mounted for Crossplane’s inner registry to recognize them.
Regarding the Crossplane CLI command you mentioned, Could you please provide me with the relevant documentation or details about the command? I’ll review it to see if we can replace the up xpkg xp-extract command with a Crossplane CLI equivalent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Documentation for the Crossplane CLI is here.
I'm not sure if extract
is an option (even as a hidden command) but can you check to see if the options match what you're doing here? I'd prefer to have the Crossplane CLI in this doc but if Crossplane doesn't provide it and we have to reference the up
CLI that's okay.
There was an offline discussion that led to #733 , that the official recommendation for offline install is to run a local container registry. This avoids issues related to implementation details for the local Crossplane package cache. I appreciate the work you put in to submit this PR but I'm going to close this now since it doesn't line up with the current Crossplane recommendations. |
This PR enhances the Crossplane documentation for offline provider installations by:
These changes aim to provide a detailed guide for setting up Crossplane providers offline.