-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maintenance toolchain update 2023 #159
Conversation
@@ -1,11 +1,16 @@ | |||
import sbtassembly.AssemblyPlugin.defaultUniversalScript | |||
|
|||
ThisBuild / scalaVersion := "2.13.6" | |||
ThisBuild / scalaVersion := "2.12.18" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is intentional, 2.13 brings 100 + deprecations,
so first, get a clean 2.12 state, and then move on
This is quite a huge update, but it makes scala 2.12.18 (latest 2.12) work with all deprecation warnings and other warnings fixed. 2.13 will bring a huge bulk of new deprecation warnings, so I keep this for a later update, since 2.12 is still maintained. |
Don't suppose you can wait until I finish with the web assembly support🤞 |
It depends on the timing. I would like to have this out and make a release with the new functionality. This might cause merge issues. No worries, I can help resolve them. Btw, this PR shows quite well the maintenance cost of code that is not in use, like the Python generator. And why I ask for additions of code that has more to show than some unit test, like a small demo app |
It's fine. Worried about conflicts, but really any conflicts from this PR are nothing next to what has to be done with the support lib 😅 |
Don't plan to add any more changes for now. Hope I will get at least some review, to not be forced to bypass our review policies |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay, and thanks for keeping this project alive :)
Since we are going to have a release soon,
It would be a good idea to update scala and sbt also
and also check the current dependencies if they need any update