Fix vertical sync issues #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… instruction is "mad" instead of "mov"
# Conflicts: # source/d3d8to9_device.cpp
Update to version 1.9.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request will fix #85. It might also be a fix for #47, but I don't have a G-Sync monitor so I cannot test is.
The issue is that the default presentation interval is
D3DPRESENT_INTERVAL_DEFAULTin both d3d8 and d3d9. However in d3d9 when using this interval it does not do vertical sync. Changing this toD3DPRESENT_INTERVAL_ONEfixes the issue. See what Microsoft says about this here:Note: I think this is a bug in Windows 10 since
D3DPRESENT_INTERVAL_DEFAULTandD3DPRESENT_INTERVAL_ONEare supposed to be the same even in d3d9. However apparently they are not. Manually changing this fixes the issue.