Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CI to pin deps and use build matrix #221

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Update CI to pin deps and use build matrix #221

merged 1 commit into from
Sep 19, 2024

Conversation

saschagrunert
Copy link
Member

What type of PR is this?

/kind ci

What this PR does / why we need it:

Update the CI to pin the dependencies, use a build matrix for the arches as well as bumping the linter.

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

None

@openshift-ci openshift-ci bot added the release-note-none Denotes a PR that doesn't merit a release note. label Sep 19, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 19, 2024

@saschagrunert: The label(s) kind/ci cannot be applied, because the repository doesn't have them.

In response to this:

What type of PR is this?

/kind ci

What this PR does / why we need it:

Update the CI to pin the dependencies, use a build matrix for the arches as well as bumping the linter.

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

None

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Sep 19, 2024
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 19, 2024
saschagrunert
saschagrunert commented Sep 19, 2024
View reviewed changes
.github/workflows/test.yaml
@@ -5,32 +5,34 @@ on: ["push", "pull_request"]

env:
GO_VERSION: "1.23"
LINUX_ARCHES: "amd64 386 arm arm64 s390x mips64le ppc64le"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dropped 386 and arm since they're not widely used any more these days.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 10938934850

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 61.458%
Totals Coverage Status
Change from base Build 10610323408: 0.0%
Covered Lines: 531
Relevant Lines: 864
💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 10938918529

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 61.458%
Totals Coverage Status
Change from base Build 10610323408: 0.0%
Covered Lines: 531
Relevant Lines: 864
💛 - Coveralls

@kwilczynski
Copy link
Member

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 19, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kwilczynski, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 94d9529 into cri-o:master Sep 19, 2024
9 checks passed
@saschagrunert saschagrunert deleted the build-matrix branch September 19, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haircommander haircommander Awaiting requested review from haircommander

@rajatchopra rajatchopra Awaiting requested review from rajatchopra

Assignees

@kwilczynski kwilczynski

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@saschagrunert @coveralls @kwilczynski