Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump CI go version and linter #218

Merged
merged 1 commit into from
Aug 26, 2024
Merged

Bump CI go version and linter #218

merged 1 commit into from
Aug 26, 2024

Conversation

saschagrunert
Copy link
Member

What type of PR is this?

/kind ci

What this PR does / why we need it:

Update the go version and the used linter.

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

None

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Aug 26, 2024

@saschagrunert: The label(s) kind/ci cannot be applied, because the repository doesn't have them.

In response to this:

What type of PR is this?

/kind ci

What this PR does / why we need it:

Update the go version and the used linter.

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

None

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Aug 26, 2024
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 26, 2024
@saschagrunert
Bump CI go version and linter
0248397 
Signed-off-by: Sascha Grunert <[email protected]>
@saschagrunert
Copy link
Member Author

@cri-o/cri-o-maintainers PTAL

@coveralls
Copy link

coveralls commented Aug 26, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10555786322

Details

  • 0 of 2 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 61.458%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/ocicni/ocicni.go 0 2 0.0%
Totals Coverage Status
Change from base Build 10555125842: 0.0%
Covered Lines: 531
Relevant Lines: 864
💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 10555770772

Details

  • 0 of 2 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 61.458%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/ocicni/ocicni.go 0 2 0.0%
Totals Coverage Status
Change from base Build 10555125842: 0.0%
Covered Lines: 531
Relevant Lines: 864
💛 - Coveralls

sohankunkerkar
sohankunkerkar approved these changes Aug 26, 2024
View reviewed changes
Copy link
Member

@sohankunkerkar sohankunkerkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 26, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Aug 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saschagrunert, sohankunkerkar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit c70acab into cri-o:master Aug 26, 2024
5 checks passed
@saschagrunert saschagrunert deleted the go-lint branch August 26, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sohankunkerkar sohankunkerkar sohankunkerkar approved these changes

@haircommander haircommander Awaiting requested review from haircommander

@sameo sameo Awaiting requested review from sameo

Assignees

@sohankunkerkar sohankunkerkar

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@saschagrunert @coveralls @sohankunkerkar