Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: refactor api for passkey module #343

Merged
merged 18 commits into from
Oct 18, 2023

Conversation

bhavanakarwade
Copy link
Contributor

@bhavanakarwade bhavanakarwade commented Oct 13, 2023

What

  • Refactor API's for passkey model.
  • Added success message and refactor typescript issues.
  • Handled conditions.
  • Resolved UI issues

Why

  • To improve code quality, performance, and bug fixing. It makes the codebase more organized and efficient.
  • To enhances user experience

@bhavanakarwade bhavanakarwade added the enhancement New feature or request label Oct 13, 2023
@bhavanakarwade bhavanakarwade self-assigned this Oct 13, 2023
@bhavanakarwade bhavanakarwade changed the base branch from main to develop October 13, 2023 12:11
Signed-off-by: bhavanakarwade <[email protected]>
setIsPasskeySuccess(true);
} else if (resetPasswordSuccess === window?.location?.search) {
setSuccess('Congratulations!! 🎉 Your new password set successfully');
}
} catch (err) {
console.log("ERROR-LOGIN::", err)
console.log('ERROR-LOGIN::', err);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the log

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resolved

@@ -205,7 +205,7 @@ const SignUpUser = () => {

<Field id='Signupemail'
name='email'
type="email"
// type="email"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove the commented code if not required

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resolved

Signed-off-by: bhavanakarwade <[email protected]>
Signed-off-by: bhavanakarwade <[email protected]>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 32 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@tipusinghaw tipusinghaw merged commit 465e4b5 into develop Oct 18, 2023
@tipusinghaw tipusinghaw deleted the refactor-api-for-passkey-module branch October 18, 2023 06:31
GHkrishna pushed a commit that referenced this pull request Sep 18, 2024
* feat: refactor api for passkey module

Signed-off-by: bhavanakarwade <[email protected]>

* feat: refactor api for passkey module

Signed-off-by: bhavanakarwade <[email protected]>

* feat: standardized API for passkey module

Signed-off-by: bhavanakarwade <[email protected]>

* add interface

Signed-off-by: bhavanakarwade <[email protected]>

* fix: sonarlint checks

Signed-off-by: bhavanakarwade <[email protected]>

* changed loader condition

Signed-off-by: bhavanakarwade <[email protected]>

* refactor api for reset password

Signed-off-by: bhavanakarwade <[email protected]>

* feat: worked on add passkey functionality in user profile

Signed-off-by: bhavanakarwade <[email protected]>

* resolved dark mode changes

Signed-off-by: bhavanakarwade <[email protected]>

* worked on alert box messages

Signed-off-by: bhavanakarwade <[email protected]>

* handle alert box conditions

Signed-off-by: bhavanakarwade <[email protected]>

---------

Signed-off-by: bhavanakarwade <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor: standardized API for passkey model (FE)
2 participants