Dialect: Fix get_pk_constraint to return list instead of set type
#26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amotl
force-pushed
the
amo/fix-get_pk_constraint
branch
2 times, most recently
from
4f59c62
to
2064d6b
Compare
amotl
commented
Jan 16, 2024
amotl
force-pushed
the
amo/fix-get_pk_constraint
branch
from
6314807
to
a649ad9
Compare
matriv
approved these changes
Jun 24, 2024
amotl
force-pushed
the
amo/fix-get_pk_constraint
branch
from
a649ad9
to
a636957
Compare
The test suite of `meltano-tap-cratedb`, derived from the corresponding
PostgreSQL adapter, will process database introspection return values by
marshalling them to JSON. Because `get_pk_constraint` returns a `set`
type, that will fail.
TypeError: Object of type set is not JSON serializable
amotl
force-pushed
the
amo/fix-get_pk_constraint
branch
from
a636957
to
37d1521
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The test suite of
meltano-tap-cratedb, derived from the corresponding PostgreSQL adapter, will process database introspection return values by marshalling them to JSON. Becauseget_pk_constraintreturns asettype, that will fail.References
This is coming from a monkeypatch to meltano-tap-cratedb.
Backlog