Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support: Generalize one more use case into support.util.refresh_table #140

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

amotl
Copy link
Member

@amotl amotl commented Jun 24, 2024

Suggestion

@seut suggested another improvement at #28 (review):

I think I'd prefer moving this quoting logic into the refresh_tablefunction, by change it's signature to consume an optional schema. This would avoid that it will be called with unquoted or invalid relation names.

Status

This patch refactors the auxiliary logic into support.util.refresh_table, but doesn't do anything else yet, in order not to complicate the interface too quickly/early.

Q&A

Maybe I am currently not seeing the spot for important improvements, which should be done right from the start: So, please advise if you still would like to introduce an optional schema name as function argument, and also please suggest further improvements you would like to see in this area.

@amotl amotl requested review from seut and matriv June 24, 2024 15:10
@amotl amotl force-pushed the amo/improve-refresh-after-dml branch from ed91bab to 6c72868 Compare June 24, 2024 15:16
@amotl amotl marked this pull request as ready for review June 24, 2024 15:19
Copy link
Member

@seut seut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx!
I think your approach with concrete argument signatures is also fine and eliminates the need for an optional table_schema argument.

@amotl amotl merged commit 7461258 into main Jun 25, 2024
27 checks passed
@amotl amotl deleted the amo/improve-refresh-after-dml branch June 25, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants