Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add azure backup capabilities #640

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add azure backup capabilities #640

wants to merge 1 commit into from

Conversation

Taliik
Copy link
Member

@Taliik Taliik commented Aug 8, 2024

Summary of changes

Checklist

  • Link to issue this PR refers to: https://github.com/crate/cloud/issues/1368
  • Relevant changes are reflected in CHANGES.rst
  • Added or changed code is covered by tests
  • Documentation has been updated if necessary
  • Changed code does not contain any breaking changes (or this is a major version change)

@Taliik Taliik force-pushed the f/add-azure-backup branch 5 times, most recently from 2d45289 to 5488448 Compare August 8, 2024 13:21
plaharanne
plaharanne approved these changes Aug 8, 2024
View reviewed changes
Copy link
Contributor

@plaharanne plaharanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Taliik Taliik force-pushed the f/add-azure-backup branch 4 times, most recently from 584fcf5 to 82fa0e1 Compare August 20, 2024 08:36
@tomach
Copy link
Contributor

tomach commented Aug 22, 2024

Probably also in the operator we would need to add the new backup location type somehow to the restoreSnapshot CRD and consider it when creating the repo for restoring a snapshot? https://github.com/crate/crate-operator/blob/f/add-azure-backup/crate/operator/restore_backup.py#L694

@cla-bot cla-bot bot added the cla-signed label Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plaharanne plaharanne plaharanne approved these changes

@tomach tomach Awaiting requested review from tomach

@WalBeh WalBeh Awaiting requested review from WalBeh

@juanpardo juanpardo Awaiting requested review from juanpardo

@widmogrod widmogrod Awaiting requested review from widmogrod

@goat-ssh goat-ssh Awaiting requested review from goat-ssh

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Taliik @tomach @plaharanne