Optionally use orc_header to detect orc version #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Linux kernel commit b9f174c811e3ae4ae8959dc57e6adb9990e913f4, a new .orc_header section was introduced. This section holds a version identifier for the ORC types in use. This patch was tested by compiling crash and using it to read coredump of kernel. A temporary print statement was added to check that the if conditions specified are working fine.
nilayvaish
commented
Feb 8, 2024
Comment on lines
+6468
to
+6469
| if (try_get_symbol_data("orc_header", sizeof(orc_header), orc_header) && | ||
| memcmp(orc_header, orc_hash_6_4, 20) == 0) { |
There was a problem hiding this comment.
We might want to move these lines since we have checks on lines 6413-6421 that can fail.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Linux kernel commit b9f174c811e3ae4ae8959dc57e6adb9990e913f4, a new .orc_header section was introduced. This section holds a version identifier for the ORC types in use.
This patch was tested by compiling crash and using it to read coredump of kernel. A temporary print statement was added to check that the if conditions specified are working fine.
#169