Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated modelinfo generation for QICore 6 and USCore 6.1.0 #514

Merged
merged 5 commits into from
May 6, 2024

Conversation

brynrhodes
Copy link
Member

Updates the modelinfo generation to support USCore 6.1.0 and QICore 6.0.0

  • I've read the contribution guidelines
  • Code compiles without errors
  • Tests are created / updated (tests are in the CQL-to-ELM translator)
  • Documentation is created / updated

By creating this PR you acknowledge that your contribution will be licensed under Apache 2.0

@ddieppois
Copy link
Contributor

We had an issue with the ModelInfo generation related to an outdated library, I'll test it after merge to confirm it works as expected !

@JPercival JPercival enabled auto-merge (squash) February 23, 2024 17:41
Copy link

codecov bot commented Mar 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 127 lines in your changes are missing coverage. Please review.

Project coverage is 20.26%. Comparing base (2148f4d) to head (2b76d88).

Files Patch % Lines
...oling/modelinfo/qicore/QICoreClassInfoBuilder.java 0.00% 78 Missing ⚠️
...oling/modelinfo/uscore/USCoreClassInfoBuilder.java 0.00% 49 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #514      +/-   ##
============================================
- Coverage     20.26%   20.26%   -0.01%     
- Complexity     1521     1522       +1     
============================================
  Files           296      296              
  Lines         25214    25229      +15     
  Branches       3980     3980              
============================================
+ Hits           5110     5112       +2     
- Misses        19256    19270      +14     
+ Partials        848      847       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JPercival JPercival disabled auto-merge May 6, 2024 17:39
@JPercival JPercival merged commit 074e341 into master May 6, 2024
4 checks passed
@JPercival JPercival deleted the feature-qicore6-modelinfo branch May 6, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants