-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace xjc with custom XSD Kotlin code gen #1479
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
antvaset
commented
Dec 18, 2024
- Add new cql.xsd-kotlin-gen-conventions plugin that runs node Src/js/xsd-kotlin-gen/generate.js.
- generate.js reads the XSD files and generates Kotlin classes with minimal imports and without annotations. Currently the input XSDs are hardcoded but should be read in from command line args.
- Add new cql.xjc-temp-conventions plugin which does the same thing as cql.xjc-conventions but skips sourceSets and sourcesJar and outputs the generated Java classes to ...-xjc-temp. This allows us to generate the Kotlin classes in place (in the same package) using the new method and have the original code also made available for comparison.
- Replace model-jaxb, model-jackson, elm-jaxb, eml-jackson with model-xmlutil and elm-xmlutil which use https://github.com/pdvrieze/xmlutil to read and write XML and JSON.
- fhir-modelinfo-3.0.1.xml and quickfhir-modelinfo-3.0.1.xml appeared to be broken and the XML deserializer was throwing "Content is not allowed in prolog". This was fixed by re-creating the files.
Formatting check succeeded! |
JPercival
approved these changes
Dec 29, 2024
Quality Gate failedFailed conditions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.