-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#1475: Fixed mapping expansions for profile-informed authoring not re… #1476
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -467,4 +467,38 @@ void abstractClassNotRetrievable() throws IOException { | |
errors.stream().map(Throwable::getMessage).collect(Collectors.toList()); | ||
assertThat(errorMessages, contains("Specified data type DomainResource does not support retrieval.")); | ||
} | ||
|
||
@Test | ||
void mappingExpansionsRespectSignatureLevel() throws IOException { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please add a test for Signature.None to contrast with the test below. Also, it might be good to test other non-Overloads, non-None Signature types as well. |
||
// See: https://github.com/cqframework/clinical_quality_language/issues/1475 | ||
final CqlTranslator translator = TestUtils.runSemanticTest( | ||
"MappingExpansionsRespectSignatureLevel.cql", 0, LibraryBuilder.SignatureLevel.Overloads); | ||
/* | ||
ExpressionDef: EncounterPeriod | ||
expression is Query | ||
return | ||
expression is FunctionRef | ||
name FHIRHelpers.ToInterval | ||
signature is NamedTypeSpecifier FHIR.Period | ||
*/ | ||
|
||
Library compiledLibrary = translator.getTranslatedLibrary().getLibrary(); | ||
List<ExpressionDef> statements = compiledLibrary.getStatements().getDef(); | ||
|
||
assertThat(statements.size(), is(2)); | ||
ExpressionDef encounterPeriod = statements.get(1); | ||
assertThat(encounterPeriod.getName(), is("EncounterPeriod")); | ||
assertThat(encounterPeriod.getExpression(), instanceOf(Query.class)); | ||
Query query = (Query) encounterPeriod.getExpression(); | ||
assertThat(query.getReturn().getExpression(), instanceOf(FunctionRef.class)); | ||
FunctionRef functionRef = (FunctionRef) query.getReturn().getExpression(); | ||
assertThat(functionRef.getLibraryName(), is("FHIRHelpers")); | ||
assertThat(functionRef.getName(), is("ToInterval")); | ||
assertThat(functionRef.getSignature(), notNullValue()); | ||
assertThat(functionRef.getSignature().size(), is(1)); | ||
assertThat(functionRef.getSignature().get(0), instanceOf(NamedTypeSpecifier.class)); | ||
NamedTypeSpecifier namedTypeSpecifier = | ||
(NamedTypeSpecifier) functionRef.getSignature().get(0); | ||
assertThat(namedTypeSpecifier.getName().getLocalPart(), is("Period")); | ||
} | ||
} |
15 changes: 15 additions & 0 deletions
15
...src/test/resources/org/cqframework/cql/cql2elm/MappingExpansionsRespectSignatureLevel.cql
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
library MappingExpansionsRespectSignatureLevel | ||
|
||
// https://github.com/cqframework/clinical_quality_language/issues/1475 | ||
|
||
using QICore version '4.1.1' | ||
|
||
include FHIRHelpers version '4.0.1' | ||
|
||
parameter "Measurement Period" Interval<DateTime> default Interval[@2024-01-01T00:00:00.0Z, @2025-01-01T00:00:00.0Z) | ||
|
||
context Patient | ||
|
||
define EncounterPeriod: | ||
[Encounter] E | ||
return E.period |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
General feedback: Please fix the title and description of this PR so at a minimum it's not a truncated version of the commit message.