Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue1469: Return false when performing 'in' on valueset with null code #1470

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

Zylox
Copy link
Contributor

@Zylox Zylox commented Dec 13, 2024

This is my first time trying to put up a pr for the project, so if there are additional steps i should be taking, i'm more than willing to learn!

@JPercival
Copy link
Contributor

Thanks for the contribution! Closes #1469 and #1048

@Zylox
Copy link
Contributor Author

Zylox commented Dec 14, 2024

I'm admittedly unsure why the "check pr" action is failing. I see @JPercival tried kicking it off twice as well to no avail.

@JPercival
Copy link
Contributor

@Zylox - Some of the github actions aren't enabled for external contributors. I need to go fix that.

@JPercival JPercival merged commit 10af73a into cqframework:master Dec 16, 2024
0 of 3 checks passed
@Zylox Zylox deleted the issue1469 branch December 16, 2024 22:36
@Zylox
Copy link
Contributor Author

Zylox commented Dec 16, 2024

Thank you so much for the assistance!

@JPercival
Copy link
Contributor

This will be in the next release later this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants