Merge Message operator tests #1402
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Formatting check succeeded! |
* WIP * WIP * WIP * Working? * Fix usage of Java 17 API * Update checkstyle rules * Fix static analysis * Updates to src dirs * Fixing up missing test sourceSet * Try another way to specify the antlr directory * Third different way * Add some logging * merge master * Change toolchain resolution * Fix tests * More tweaks to animalsniffer * Fix formatting * Trying random stuff * More random stuff * Small improvements for Gradle build (#1418) * Removing references to idea * Fix duplicative generation * Remove references to idea project generation --------- Co-authored-by: Anton Vasetenkov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merged tests from
engine/.../CqlErrorsAndMessagingOperatorsTest.cqlintoCqlErrorsAndMessagingOperatorsTest.xml.Keeping the CQL library with the following define's:
Messageoperator with the'Message','Warning', and'Trace'severities:'Error'(I also adjusted the Java tests for these define's so that they fail if the engine does not throw):Note that
TestErrorWithNullConditiondefined asis not supposed to throw because the spec says, "If condition is true, the message is generated. Otherwise, the operation only returns the results and performs no processing at all."
At the moment this is a draft and depends on #1401. Once I'm sure we can have
Messagecalls withnulls without casts, I'll raise a corresponding PR to update cql-tests.