search: clarify that the case of the name is as requested or all lower
#77
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This means that if the requester (whether that is directly from a user or from another CPS file) specifies the name in a case that is not all lower, search for that exactly as well as the all lower. For example, if "OpenGL" is requested, then the name should be searched as "OpenGL" and as "opengl".
dcbaker
force-pushed
the
submit/clarify-name-case
branch
from
218dae7
to
e2ce148
Compare
mwoehlke
approved these changes
Sep 30, 2024
|
Sigh, I give up waiting on a second approval. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This means that if the requester (whether that is directly from a user or from another CPS file) specifies the name in a case that is not all lower, search for that exactly as well as the all lower.
For example, if "OpenGL" is requested, then the name should be searched as "OpenGL" and as "opengl".
I struggled a little bit with what to call the "requester", which I still don't like but can't come up with anything better.