Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parser accepts elastic and sink bodies #118

Merged
merged 2 commits into from
Jan 6, 2025
Merged

parser accepts elastic and sink bodies #118

merged 2 commits into from
Jan 6, 2025

Conversation

ashtum
Copy link
Collaborator

@ashtum ashtum commented Jan 6, 2025

No description provided.

@ashtum ashtum force-pushed the parser-accepts-elastic-and-sink-bodies branch 3 times, most recently from c6cd67b to 6e00ba3 Compare January 6, 2025 14:32
@cppalliance-bot
Copy link

GCOVR code coverage report https://118.http-proto.prtest.cppalliance.org/gcovr/index.html
LCOV code coverage report https://118.http-proto.prtest.cppalliance.org/genhtml/index.html
Coverage Diff https://118.http-proto.prtest.cppalliance.org/gcovr/coverage_diff.txt

@ashtum ashtum force-pushed the parser-accepts-elastic-and-sink-bodies branch 2 times, most recently from 0238653 to b4db8fa Compare January 6, 2025 15:06
@cppalliance-bot
Copy link

GCOVR code coverage report https://118.http-proto.prtest.cppalliance.org/gcovr/index.html
LCOV code coverage report https://118.http-proto.prtest.cppalliance.org/genhtml/index.html
Coverage Diff https://118.http-proto.prtest.cppalliance.org/gcovr/coverage_diff.txt

@codecov Codecov
Copy link

codecov bot commented Jan 6, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 81.72043% with 68 lines in your changes missing coverage. Please review.

Project coverage is 91.11%. Comparing base (ef6753a) to head (6532056).
Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
src/parser.cpp 84.12% 57 Missing ⚠️
src/file_body.cpp 0.00% 11 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #118      +/-   ##
===========================================
+ Coverage    90.11%   91.11%   +1.00%     
===========================================
  Files           81       81              
  Lines         4854     4807      -47     
===========================================
+ Hits          4374     4380       +6     
+ Misses         480      427      -53
Files with missing lines Coverage Δ
include/boost/http_proto/parser.hpp 100.00% <100.00%> (ø)
src/file_body.cpp 0.00% <0.00%> (ø)
src/parser.cpp 89.12% <84.12%> (+5.34%) ⬆️

... and 2 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef6753a...6532056. Read the comment docs.

@cppalliance-bot
Copy link

GCOVR code coverage report https://118.http-proto.prtest.cppalliance.org/gcovr/index.html
LCOV code coverage report https://118.http-proto.prtest.cppalliance.org/genhtml/index.html
Coverage Diff https://118.http-proto.prtest.cppalliance.org/gcovr/coverage_diff.txt

@ashtum ashtum force-pushed the parser-accepts-elastic-and-sink-bodies branch 3 times, most recently from 14114dc to cb640ef Compare January 6, 2025 16:51
@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://118.http-proto.prtest.cppalliance.org/index.html

@ashtum ashtum force-pushed the parser-accepts-elastic-and-sink-bodies branch from cb640ef to 8a00068 Compare January 6, 2025 17:01
@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://118.http-proto.prtest.cppalliance.org/index.html

@ashtum ashtum force-pushed the parser-accepts-elastic-and-sink-bodies branch from 8a00068 to 5e7b2e0 Compare January 6, 2025 17:11
@cppalliance-bot
Copy link

GCOVR code coverage report https://118.http-proto.prtest.cppalliance.org/gcovr/index.html
LCOV code coverage report https://118.http-proto.prtest.cppalliance.org/genhtml/index.html
Coverage Diff https://118.http-proto.prtest.cppalliance.org/gcovr/coverage_diff.txt

@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://118.http-proto.prtest.cppalliance.org/index.html

@cppalliance-bot
Copy link

GCOVR code coverage report https://118.http-proto.prtest.cppalliance.org/gcovr/index.html
LCOV code coverage report https://118.http-proto.prtest.cppalliance.org/genhtml/index.html
Coverage Diff https://118.http-proto.prtest.cppalliance.org/gcovr/coverage_diff.txt

@ashtum ashtum force-pushed the parser-accepts-elastic-and-sink-bodies branch 2 times, most recently from 4716b55 to d042131 Compare January 6, 2025 17:33
@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://118.http-proto.prtest.cppalliance.org/index.html

@ashtum ashtum force-pushed the parser-accepts-elastic-and-sink-bodies branch from d042131 to ec969a3 Compare January 6, 2025 17:42
@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://118.http-proto.prtest.cppalliance.org/index.html

@cppalliance-bot
Copy link

GCOVR code coverage report https://118.http-proto.prtest.cppalliance.org/gcovr/index.html
LCOV code coverage report https://118.http-proto.prtest.cppalliance.org/genhtml/index.html
Coverage Diff https://118.http-proto.prtest.cppalliance.org/gcovr/coverage_diff.txt

vinniefalco
vinniefalco reviewed Jan 6, 2025
View reviewed changes
src/parser.cpp Outdated Show resolved Hide resolved
@cppalliance-bot
Copy link

GCOVR code coverage report https://118.http-proto.prtest.cppalliance.org/gcovr/index.html
LCOV code coverage report https://118.http-proto.prtest.cppalliance.org/genhtml/index.html
Coverage Diff https://118.http-proto.prtest.cppalliance.org/gcovr/coverage_diff.txt

@ashtum ashtum force-pushed the parser-accepts-elastic-and-sink-bodies branch from ec969a3 to 6532056 Compare January 6, 2025 18:21
@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://118.http-proto.prtest.cppalliance.org/index.html

@cppalliance-bot
Copy link

GCOVR code coverage report https://118.http-proto.prtest.cppalliance.org/gcovr/index.html
LCOV code coverage report https://118.http-proto.prtest.cppalliance.org/genhtml/index.html
Coverage Diff https://118.http-proto.prtest.cppalliance.org/gcovr/coverage_diff.txt

@ashtum ashtum merged commit 72b6a95 into cppalliance:develop Jan 6, 2025
60 of 61 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinniefalco vinniefalco vinniefalco left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ashtum @cppalliance-bot @vinniefalco