zlib::service refactor
#108
Conversation
|
Antora version: an automated preview of the documentation is available at https://108.http-proto.prtest.cppalliance.org/site/index.html |
| install_service(context& ctx); | ||
|
|
||
| } // zlib | ||
| } // http_proto | ||
| } // boost | ||
|
|
||
| #include <boost/http_proto/service/impl/zlib_service.hpp> |
There was a problem hiding this comment.
we don't do this anymore... everything goes in the compiled lib
There was a problem hiding this comment.
The contents of impl/zlib_service.hpp are declarations and constexpr functions, which must be placed in header files.
This is similar to: https://github.com/cppalliance/http_proto/blob/develop/include/boost/http_proto/impl/error.hpp
| namespace detail { | ||
|
|
||
| struct BOOST_SYMBOL_VISIBLE | ||
| error_cat_type |
There was a problem hiding this comment.
I didn't realize URL put so much in the headers. Is this the best technique? Maybe... I can't remember why though.
| BOOST_SYSTEM_CONSTEXPR | ||
| system::error_code | ||
| make_error_code( | ||
| error ev) noexcept |
There was a problem hiding this comment.
I guess making this function inline has performance advantages for things like comparisons to error?
There was a problem hiding this comment.
I believe that since system::error_code can be constructed at compile time, we need to make make_error_code constexpr to enable that feature for our error types.
|
GCOVR code coverage report https://108.http-proto.prtest.cppalliance.org/gcovr/index.html |
|
Your javadocs need work but this is a long-term problem. From now on please try to make them as descriptive as possible. |
ashtum
force-pushed
the
zlib-service-refactor
branch
from
c5ba050 to
61bf7a0
Compare
|
Antora version: an automated preview of the documentation is available at https://108.http-proto.prtest.cppalliance.org/site/index.html |
|
GCOVR code coverage report https://108.http-proto.prtest.cppalliance.org/gcovr/index.html |
ashtum
force-pushed
the
zlib-service-refactor
branch
from
61bf7a0 to
ec9732f
Compare
|
Antora version: an automated preview of the documentation is available at https://108.http-proto.prtest.cppalliance.org/site/index.html |
|
GCOVR code coverage report https://108.http-proto.prtest.cppalliance.org/gcovr/index.html |
ashtum
force-pushed
the
zlib-service-refactor
branch
from
ec9732f to
54ea11d
Compare
|
Antora version: an automated preview of the documentation is available at https://108.http-proto.prtest.cppalliance.org/site/index.html |
ashtum
force-pushed
the
zlib-service-refactor
branch
from
54ea11d to
d533d2c
Compare
|
Antora version: an automated preview of the documentation is available at https://108.http-proto.prtest.cppalliance.org/site/index.html |
|
GCOVR code coverage report https://108.http-proto.prtest.cppalliance.org/gcovr/index.html |
ashtum
force-pushed
the
zlib-service-refactor
branch
from
d533d2c to
72beced
Compare
|
Antora version: an automated preview of the documentation is available at https://108.http-proto.prtest.cppalliance.org/site/index.html |
|
GCOVR code coverage report https://108.http-proto.prtest.cppalliance.org/gcovr/index.html |
1 similar comment
|
GCOVR code coverage report https://108.http-proto.prtest.cppalliance.org/gcovr/index.html |
ashtum
force-pushed
the
zlib-service-refactor
branch
from
72beced to
1c4a5c9
Compare
|
Antora version: an automated preview of the documentation is available at https://108.http-proto.prtest.cppalliance.org/site/index.html |
ashtum
force-pushed
the
zlib-service-refactor
branch
from
1c4a5c9 to
5db9d14
Compare
|
Antora version: an automated preview of the documentation is available at https://108.http-proto.prtest.cppalliance.org/site/index.html |
ashtum
force-pushed
the
zlib-service-refactor
branch
from
5db9d14 to
a44dfe9
Compare
|
Antora version: an automated preview of the documentation is available at https://108.http-proto.prtest.cppalliance.org/site/index.html |
|
GCOVR code coverage report https://108.http-proto.prtest.cppalliance.org/gcovr/index.html |
1 similar comment
|
GCOVR code coverage report https://108.http-proto.prtest.cppalliance.org/gcovr/index.html |
ashtum
force-pushed
the
zlib-service-refactor
branch
from
a44dfe9 to
2d5e435
Compare
|
Antora version: an automated preview of the documentation is available at https://108.http-proto.prtest.cppalliance.org/site/index.html |
ashtum
force-pushed
the
zlib-service-refactor
branch
from
2d5e435 to
9eb2593
Compare
|
GCOVR code coverage report https://108.http-proto.prtest.cppalliance.org/gcovr/index.html |
|
Antora version: an automated preview of the documentation is available at https://108.http-proto.prtest.cppalliance.org/site/index.html |
ashtum
force-pushed
the
zlib-service-refactor
branch
from
9eb2593 to
dd5b1c7
Compare
|
GCOVR code coverage report https://108.http-proto.prtest.cppalliance.org/gcovr/index.html |
|
Antora version: an automated preview of the documentation is available at https://108.http-proto.prtest.cppalliance.org/site/index.html |
|
GCOVR code coverage report https://108.http-proto.prtest.cppalliance.org/gcovr/index.html |
ashtum
force-pushed
the
zlib-service-refactor
branch
from
dd5b1c7 to
ce501cb
Compare
|
Antora version: an automated preview of the documentation is available at https://108.http-proto.prtest.cppalliance.org/site/index.html |
|
GCOVR code coverage report https://108.http-proto.prtest.cppalliance.org/gcovr/index.html |
No description provided.