filter is an implementation detail
#103
Conversation
| class BOOST_HTTP_PROTO_DECL | ||
| filter | ||
| : public buffered_base | ||
| class filter |
There was a problem hiding this comment.
this type is still publicly visible. can't we just forward-declare it and only declare it in the .cpp files?
There was a problem hiding this comment.
yes, we can forward declare it and add filter.hpp to src.
|
Antora version: an automated preview of the documentation is available at https://103.http-proto.prtest.cppalliance.org/site/index.html |
ashtum
force-pushed
the
filter-is-an-implementation-detail
branch
from
86dbc0e to
41ee9b0
Compare
| @@ -335,7 +335,7 @@ init(bool use_gzip) | |||
| stream_.avail_in = 0; | |||
| } | |||
|
|
|||
| filter::results | |||
| http_proto::detail::filter::results | |||
There was a problem hiding this comment.
auto with a trailing return type might make this shorter?
There was a problem hiding this comment.
deflate_filter is in a different namespace. we need the whole http_proto::detail::filter::results.
|
I left one comment, otherwise this seems OK. |
|
Antora version: an automated preview of the documentation is available at https://103.http-proto.prtest.cppalliance.org/site/index.html |
ashtum
force-pushed
the
filter-is-an-implementation-detail
branch
from
41ee9b0 to
e065579
Compare
|
Antora version: an automated preview of the documentation is available at https://103.http-proto.prtest.cppalliance.org/site/index.html |
ashtum
force-pushed
the
filter-is-an-implementation-detail
branch
from
e065579 to
0bc02e4
Compare
ashtum
force-pushed
the
filter-is-an-implementation-detail
branch
from
0bc02e4 to
55af300
Compare
|
Antora version: an automated preview of the documentation is available at https://103.http-proto.prtest.cppalliance.org/site/index.html |
|
GCOVR code coverage report https://103.http-proto.prtest.cppalliance.org/gcovr/index.html |
|
GCOVR code coverage report https://103.http-proto.prtest.cppalliance.org/gcovr/index.html |
No description provided.