[expr.const] Properly merge P2686R5 #7533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
P2686R5 (applied by commit e220906) accidentally reverted a change considering erroneous values made by P2795R5.
|
@tkoeppe , Nov 2024 motions application editorially introduced a regression that is fixed by this pull request. Please consider ASAP. |
|
Thanks! I did look at that briefly and wasn't quite sure but failed follow up -- thanks a lot for catching this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
P2686R5 (applied by commit e220906) accidentally reverted a change considering erroneous values made by P2795R5.
Fixes cplusplus/CWG#662