-
Notifications
You must be signed in to change notification settings - Fork 675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add insulinDelivery support for iOS #675
Add insulinDelivery support for iOS #675
Conversation
In order to write insulin delivery to apple health we need to provide a reason (basal vs bolus) so I've decided to create a new method channel for it. Please check if that makes sense to you! Also check if exposing metadata on HealthDataPoint makes sense. |
@MadsVSChristensen sorry to tag you, but just wanted to ask if it's possible to consider this pull request for future releases? Cheers |
@hoffmatteo I've just merged this branch with the latest changes so it should be easier to review, whenever you find time to pick this up 🙂 |
Sorry, this PR had some issues, but now everything is working as expected and updated until version 8.1.0, ready for review and merge 👍 |
@bardram Hello 👋 any chance of taking a look into this one? 🙏 |
…ion allways needs to be set to prevent crash)
Hi @biklas7, thanks for your PR and apologies for the long delay. I will review this within the next couple of days. |
Thank you for your contribution and effort, we appreciate that! I made one minor change which is to throw an exception when you try calling your write method on Android, consistent with the existing We will try to release this in the coming week. |
Thanks for the review @SlimShadyIAm and glad to contribute 👍 |
Closes #674