Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add insulinDelivery support for iOS #675

Merged
merged 33 commits into from
Jul 26, 2024

Conversation

biklas7
Copy link
Contributor

@biklas7 biklas7 commented Feb 20, 2023

Closes #674

@biklas7 biklas7 marked this pull request as draft February 21, 2023 16:02
@biklas7
Copy link
Contributor Author

biklas7 commented Feb 21, 2023

In order to write insulin delivery to apple health we need to provide a reason (basal vs bolus) so I've decided to create a new method channel for it. Please check if that makes sense to you!

Also check if exposing metadata on HealthDataPoint makes sense.

@biklas7 biklas7 marked this pull request as ready for review February 21, 2023 18:58
@biklas7
Copy link
Contributor Author

biklas7 commented Apr 3, 2023

@MadsVSChristensen sorry to tag you, but just wanted to ask if it's possible to consider this pull request for future releases? Cheers

@biklas7
Copy link
Contributor Author

biklas7 commented Jan 2, 2024

@hoffmatteo I've just merged this branch with the latest changes so it should be easier to review, whenever you find time to pick this up 🙂

@biklas7
Copy link
Contributor Author

biklas7 commented Jan 10, 2024

Sorry, this PR had some issues, but now everything is working as expected and updated until version 8.1.0, ready for review and merge 👍

@biklas7
Copy link
Contributor Author

biklas7 commented Jul 10, 2024

@bardram Hello 👋 any chance of taking a look into this one? 🙏

António Valente added 2 commits July 15, 2024 15:06
@SlimShadyIAm
Copy link
Contributor

Hi @biklas7, thanks for your PR and apologies for the long delay. I will review this within the next couple of days.

@SlimShadyIAm
Copy link
Contributor

Thank you for your contribution and effort, we appreciate that!

I made one minor change which is to throw an exception when you try calling your write method on Android, consistent with the existing writeAudiogram method.

We will try to release this in the coming week.

@SlimShadyIAm SlimShadyIAm merged commit dc2eed8 into cph-cachet:master Jul 26, 2024
1 check passed
@biklas7
Copy link
Contributor Author

biklas7 commented Jul 26, 2024

Thanks for the review @SlimShadyIAm and glad to contribute 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[health 4.5.0] Add support for insulinDelivery type from HealthKit
3 participants